Add module for the switching endpoint of the API:

[earendilfr]

Permit to close the following tasks:

• list_fdb #72
• get_link #73
• get_links #74
• list_links #75
• get_vlans #76
• list_vlans #77

[WhaleJ84]

Finished reviewing; works perfectly fine on my end. All the recommendations above are minor and I can do myself but I thought I'd note them down in case you want to resolve them yourself. Will merge in if no reply is given after 3 days. Thanks for adding!

[WhaleJ84]

Moving to own comment, as it looks like I'm calling it an issue in the code

I appreciate the addition of the docstring entry on line 55! I should probably make note of these documentation inconsistencies and submit issues in the official repo

[earendilfr]

Ok: I have updated the PR with the recommendation provide by pylint.

Just one question: for your second remarks: did you prefer I replace

      def get_link(self, link: int):
      ¦   """
      ¦   Retrieves Link by ID
  
      ¦   :param link: Should be a link ID (integer)
      ¦   """

by

      def get_link(self, link: str):
      ¦   """
      ¦   Retrieves Link by ID
  
      ¦   :param link: Should be a link ID
      ¦   """

[WhaleJ84]

Ok: I have updated the PR with the recommendation provide by pylint.

Just one question: for your second remarks: did you prefer I replace

      def get_link(self, link: int):
      ¦   """
      ¦   Retrieves Link by ID
  
      ¦   :param link: Should be a link ID (integer)
      ¦   """

by

      def get_link(self, link: str):
      ¦   """
      ¦   Retrieves Link by ID
  
      ¦   :param link: Should be a link ID
      ¦   """

I tested both strings and integers and they both work. In my experience, the LibreNMS API tends to prefer string interpretations of integers, so I would go with strings. You could always do a Union instead and accept both.

[earendilfr]

Ok: I have updated the PR with the recommendation provide by pylint.
Just one question: for your second remarks: did you prefer I replace

      def get_link(self, link: int):
      ¦   """
      ¦   Retrieves Link by ID
  
      ¦   :param link: Should be a link ID (integer)
      ¦   """

by

      def get_link(self, link: str):
      ¦   """
      ¦   Retrieves Link by ID
  
      ¦   :param link: Should be a link ID
      ¦   """

I tested both strings and integers and they both work. In my experience, the LibreNMS API tends to prefer string interpretations of integers, so I would go with strings. You could always do a Union instead and accept both.

OK: so, i have updated the PR and now use str as parameter.