Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate test case expectation discrepancies #6

Closed
joanmarie opened this issue Feb 22, 2018 · 2 comments
Closed

Investigate test case expectation discrepancies #6

joanmarie opened this issue Feb 22, 2018 · 2 comments

Comments

@joanmarie
Copy link

Test case expectation discrepancies

  1. Name test case 543. Becase "Reset" is the displayed text on the push button, and there is no other name source, "Reset" should be exposed as the accessible name. WhatSock's tool shows the empty string as the calculated accessible name. Please verify that the spec includes this scenario in its algorithm and that the error is in the tool.

  2. Name test cases 548, 733, 734, 735, 736, and 737. (These are essentially the same test, but with a different input type.) Our expectation is "crazy clown"; WhatSock's tool shows "crazy beard". Please verify the tool is correct according to the algorithm in the spec.

  3. Name test case 600. Our expectation is the empty string; WhatSock's tool shows "Div with text". In this particular case, I think our expectation is correct. We do not want divs (or paragraphs or any other non interactive, textual element) to have accessible name calculated from content. Many divs, etc. have a bunch of text. And at least some screen readers will present the accessible name if there is one. Imagine arrowing down into a huge div/paragraph and having the screen reader spew out its full contents.

  4. Name test cases 661, 662, 663, and 663a. (These are essentially the same test, but with a different input type.) Our expectation is a name of "foo bar baz"; WhatSock's tool is a name of "foobaz" and a description of "bar". I'll add a description test for the same markup. In the meantime, please verify the tool is correct according to the algorithm in the spec.

  5. Name test cases checkbox-label-embedded-combobox, file-label-embedded-combobox, password-label-embedded-combobox, radio-label-embedded-combobox, text-label-embedded-combobox. (These are essentially the same test, but with a different input type.) Our expectation is a name of "Flash the screen 1 times." WhatSock's tool is a name of "Flash the screen 1 2 3 times." Here the numbers come from the list item text, and only the item with "1" has aria-selected="true". Is this scenario covered by the algorithm? If not, it should be. If it is, please verify that the tool has the correct expectations.

  6. Name test cases checkbox-label-embedded-menu, file-label-embedded-menu, password-label-embedded-menu, radio-label-embedded-menu, text-label-embedded-menu. (These are essentially the same test, but with a different input type.) Our expectation is a name of "Flash the screen 1 times." WhatSock's tool is a name of "Flash the screen times." This is a variant of the previous test case. Determining whether or not our algorithm covers inclusion of aria-selected="true" in the name calculation is needed.

@accdc
Copy link
Collaborator

accdc commented Feb 26, 2018 via email

@joanmarie
Copy link
Author

I think that everything in this issue has been addressed. I've opened new issues for things where the discrepancy is between the test expectations and the implementations and my initial finding is that the implementation is correct and that the expectations (WG and WhatSock) are wrong. As a result, I am going to close this as fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants