as patterns on both sides (#519)

WhatsApp · Feb 19, 2021 · 0eb8278 · 0eb8278
1 parent 6179ec4
commit 0eb8278
Show file tree

Hide file tree

Showing 3 changed files with 115 additions and 0 deletions.
diff --git a/eqwalizer/src/main/scala/com/whatsapp/eqwalizer/tc/ElabPat.scala b/eqwalizer/src/main/scala/com/whatsapp/eqwalizer/tc/ElabPat.scala
@@ -68,6 +68,9 @@ final class ElabPat(module: String) {
                 (ListType(Subtype.join(hType, refinedT)), env2)
             }
         }
+      case PatMatch(p1: PatVar, p2) =>
+        val (t2, env1) = elabPat(p2, t, env)
+        elabPat(p1, t2, env1)
       case PatMatch(p1, p2) =>
         val (t1, env1) = elabPat(p1, t, env)
         elabPat(p2, t1, env1)

diff --git a/eqwalizer/test_projects/check/src/as_pat.erl b/eqwalizer/test_projects/check/src/as_pat.erl
@@ -0,0 +1,56 @@
+-module(as_pat).
+
+-compile([export_all, nowarn_export_all]).
+
+-record(box_a, {a :: atom()}).
+-record(box_b, {b :: binary()}).
+-record(box_n, {n :: number()}).
+
+-type abn() :: atom() | binary() | number().
+
+-type box() :: #box_a{}
+             | #box_b{}
+             | #box_n{}.
+
+-spec box_a(atom()) -> #box_a{}.
+box_a(A) -> #box_a{a = A}.
+
+-spec unbox_a(#box_a{}) -> atom().
+unbox_a(#box_a{a = A}) -> A.
+
+-spec box_n(number()) -> #box_n{}.
+box_n(N) -> #box_n{n = N}.
+
+-spec unbox_n(#box_n{}) -> number().
+unbox_n(#box_n{n = N}) -> N.
+
+-spec box_b(binary()) -> #box_b{}.
+box_b(B) -> #box_b{b = B}.
+
+-spec unbox_b(#box_b{}) -> binary().
+unbox_b({b, B}) -> B.
+
+-spec unbox(box()) -> abn().
+unbox(#box_a{a = A}) -> A;
+unbox(#box_b{b = B}) -> B;
+unbox(#box_n{n = N}) -> N.
+
+-spec unboxL(box()) -> abn().
+unboxL(BA = #box_a{}) -> unbox_a(BA);
+unboxL(BB = #box_b{}) -> unbox_b(BB);
+unboxL(BN = #box_n{}) -> unbox_n(BN).
+
+-spec unboxL_neg(box()) -> abn().
+unboxL_neg(BA = #box_a{}) -> unbox_a(BA);
+unboxL_neg(BB = #box_b{}) -> unbox_b(BB);
+unboxL_neg(BN = #box_n{}) -> unbox_a(BN).
+
+-spec unboxR(box()) -> abn().
+unboxR(#box_a{} = BA) -> unbox_a(BA);
+unboxR(#box_b{} = BB) -> unbox_b(BB);
+unboxR(#box_n{} = BN) -> unbox_n(BN).
+
+-spec unboxR_neg(box()) -> abn().
+unboxR_neg(#box_a{} = BA) -> unbox_a(BA);
+unboxR_neg(#box_b{} = BB) -> unbox_b(BB);
+unboxR_neg(#box_n{} = BN) -> unbox_b(BN).
diff --git a/eqwalizer/test_projects/check/src/as_pat.erl.check b/eqwalizer/test_projects/check/src/as_pat.erl.check
@@ -0,0 +1,56 @@
+  1 -module(as_pat).                           |         | 
+  2                                            |         | 
+  3 -compile([export_all, nowarn_export_all]). |         | 
+  4                                            |         | 
+  5 -record(box_a, {a :: atom()}).             |         | 
+  6 -record(box_b, {b :: binary()}).           |         | 
+  7 -record(box_n, {n :: number()}).           |         | 
+  8                                            |         | 
+  9 -type abn() :: atom() | binary() | number(……         | 
+ 10                                            |         | 
+ 11 -type box() :: #box_a{}                    |         | 
+ 12              | #box_b{}                    |         | 
+ 13              | #box_n{}.                   |         | 
+ 14                                            |         | 
+ 15 -spec box_a(atom()) -> #box_a{}.           |         | 
+ 16 box_a(A) -> #box_a{a = A}.                 | OK      | 
+ 17                                            |         | 
+ 18 -spec unbox_a(#box_a{}) -> atom().         |         | 
+ 19 unbox_a(#box_a{a = A}) -> A.               | OK      | 
+ 20                                            |         | 
+ 21 -spec box_n(number()) -> #box_n{}.         |         | 
+ 22 box_n(N) -> #box_n{n = N}.                 | OK      | 
+ 23                                            |         | 
+ 24 -spec unbox_n(#box_n{}) -> number().       |         | 
+ 25 unbox_n(#box_n{n = N}) -> N.               | OK      | 
+ 26                                            |         | 
+ 27 -spec box_b(binary()) -> #box_b{}.         |         | 
+ 28 box_b(B) -> #box_b{b = B}.                 | OK      | 
+ 29                                            |         | 
+ 30 -spec unbox_b(#box_b{}) -> binary().       |         | 
+ 31 unbox_b({b, B}) -> B.                      | OK      | 
+ 32                                            |         | 
+ 33 -spec unbox(box()) -> abn().               |         | 
+ 34 unbox(#box_a{a = A}) -> A;                 | OK      | 
+ 35 unbox(#box_b{b = B}) -> B;                 |         | 
+ 36 unbox(#box_n{n = N}) -> N.                 |         | 
+ 37                                            |         | 
+ 38 -spec unboxL(box()) -> abn().              |         | 
+ 39 unboxL(BA = #box_a{}) -> unbox_a(BA);      | OK      | 
+ 40 unboxL(BB = #box_b{}) -> unbox_b(BB);      |         | 
+ 41 unboxL(BN = #box_n{}) -> unbox_n(BN).      |         | 
+ 42                                            |         | 
+ 43 -spec unboxL_neg(box()) -> abn().          |         | 
+ 44 unboxL_neg(BA = #box_a{}) -> unbox_a(BA);  | ERROR   | 
+ 45 unboxL_neg(BB = #box_b{}) -> unbox_b(BB);  |         | 
+ 46 unboxL_neg(BN = #box_n{}) -> unbox_a(BN).  |         | BN. Expected: #box_a{}, Got: #box_n{}
+ 47                                            |         | 
+ 48 -spec unboxR(box()) -> abn().              |         | 
+ 49 unboxR(#box_a{} = BA) -> unbox_a(BA);      | OK      | 
+ 50 unboxR(#box_b{} = BB) -> unbox_b(BB);      |         | 
+ 51 unboxR(#box_n{} = BN) -> unbox_n(BN).      |         | 
+ 52                                            |         | 
+ 53 -spec unboxR_neg(box()) -> abn().          |         | 
+ 54 unboxR_neg(#box_a{} = BA) -> unbox_a(BA);  | ERROR   | 
+ 55 unboxR_neg(#box_b{} = BB) -> unbox_b(BB);  |         | 
+ 56 unboxR_neg(#box_n{} = BN) -> unbox_b(BN).  |         | BN. Expected: #box_b{}, Got: #box_n{}