Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-factoring : #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re-factoring : #16

wants to merge 1 commit into from

Conversation

aelharrak
Copy link

  • Add repository less/skeleton to simplifying the integration of skeleton framework into any projects (existing / new).
  • Update package.json.
  • Add css minification -- >skeleton.min.css with 6ko :)
  • Separation of code into small files (help to use specific file if needed ).
  • Use more Less syntax

- Add repository less/skeleton to simplifying the integration of skeleton framework into any projects (existing / new).
- Update package.json.
- Add css minification -- >skeleton.min.css with 6ko :)
- Separation of code into small files (help to use specific file if needed ).
- Use more Less syntax
@aelharrak
Copy link
Author

Hello Can you confirm please ?

@WhatsNewSaes
Copy link
Owner

WhatsNewSaes commented Jun 28, 2016

@aelharrak thanks so much for adding these. Let me review.

@aelharrak
Copy link
Author

Hello,

Ok i'm waiting for PR ;)

BR,
Amine

2016-06-28 23:56 GMT+00:00 Seth Coelen notifications@github.com:

@aelharrak https://github.com/aelharrak thanks so much for adding
these. Let me review. My only concern is keeping the my Skeleton-Sass
https://github.com/WhatsNewSaes/Skeleton-Sass repo consistent and up to
date with my Skeleton-less and vice versa.

Would you be interested in replicating in the sass repo if these changes
are accepted?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACUywN1Z5OsVUCvTYuNY0Nl7bH_TOUnWks5qQbSZgaJpZM4I-8zB
.

Cordialement,

http://about.me/amine.elharrak

[image: EL HARRAK AMINE on about.me]

EL HARRAK AMINE
about.me/amine.elharrak - Ingénieur concepteur développeur SQLI - Rabat
http://about.me/amine.elharrak +212 (0)665 94 23 73

@filecage
Copy link

PR would conflict with PR #15. Although this seems to be a better approach, it does not provide same functionality as in #15 (overwriting default variables) and is incomplete (missing minor version raise).

@filecage
Copy link

@WhatsNewSaes I don't see why reviewing this or my PR #15 would take about 3 months. If you're no longer interested in maintaining the project, please consider adding another contributor to allow further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants