Create .gitattributes #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Just noticed a small potential problem... https://github.com/WhichBrowser/Parser-PHP/blob/27f37af/composer.json#L23 Tests are autoloaded into the same namespace, so with the code as is, composer is presumably going to try and load the test files too whatever... Needs a bit of testing (before the next release)... If it does break things, mind if I add a PR to move tests to `WhichBrowser\Tests`` or something and update composer.json accordingly? Or maybe try https://getcomposer.org/doc/04-schema.md#exclude-files-from-classmaps |
|
Looks like it works fine as is, so no further changes needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.