Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.2 compatibility #673

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Add PHP 8.2 compatibility #673

merged 1 commit into from
Apr 16, 2024

Conversation

javer
Copy link
Contributor

@javer javer commented Oct 2, 2022

@javer
Copy link
Contributor Author

javer commented Oct 19, 2022

@NielsLeenheer Could you please take a look at this small fix?

@javer
Copy link
Contributor Author

javer commented Dec 2, 2022

@NielsLeenheer Any updates on this? PHP 8.2 will be released in a week.

@thinhbuzz
Copy link

@NielsLeenheer any update?

@ldebrouwer
Copy link

It'd be great to get this merged, as it would unblock my PHP 8.2 upgrade as well.

@ldebrouwer ldebrouwer mentioned this pull request Dec 16, 2022
Closed
@acelaya acelaya mentioned this pull request Jan 3, 2023
Closed
12 tasks
@javer
Copy link
Contributor Author

javer commented Jan 9, 2023

Hi! Do you have any plans to merge PR this year?

@ldebrouwer
Copy link

@NielsLeenheer Hi Niels, is there anything we can do to help get the ball rolling on this PR?

@javer
Copy link
Contributor Author

javer commented Apr 24, 2023

Is there any update on this?

@marc-farre
Copy link

Same problem here, could this PR be merged and a new version released?
Thanks a lot for this great library!

@nadar
Copy link

nadar commented May 31, 2023

🙏

@mkoprek
Copy link

mkoprek commented Jun 13, 2023

Guys, please mark this library as abandoned. If you are not able to merge simple PR with some deprecations.

@mkoprek mkoprek mentioned this pull request Aug 30, 2023
Closed
@nadar
Copy link

nadar commented Oct 23, 2023 •
edited
Loading

I have published a fork with the fixes on the same namespace. Replace "whichbrowser/parser": "2.1.7", with "nadar/parser": "^1.1" in composer.json and you are done.

https://github.com/nadar/Parser-PHP

@a1812 a1812 mentioned this pull request Apr 15, 2024
Closed
NielsLeenheer
NielsLeenheer approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@NielsLeenheer NielsLeenheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a long time to get back to WhichBrowser, but thanks for this!

@NielsLeenheer NielsLeenheer merged commit 6ed98e1 into WhichBrowser:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NielsLeenheer NielsLeenheer NielsLeenheer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@javer @thinhbuzz @ldebrouwer @marc-farre @nadar @mkoprek @NielsLeenheer