Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix downloadMediaMessage crash with ptv messages #356

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix downloadMediaMessage crash with ptv messages #356

merged 1 commit into from
Oct 16, 2023

Conversation

brhenrique
Copy link
Contributor

@brhenrique brhenrique commented Aug 30, 2023 •
edited
Loading

downloadMediaMessage crashes when trying to download the media from PTV messages (those video circles).

This fixes it by extending the HKDF map to account for PTV messages

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@brhenrique/Baileys#fix-downloadMediaMessage-crash-on-ptv
# YARN v2
yarn add @whiskeysockets/baileys@brhenrique/Baileys#fix-downloadMediaMessage-crash-on-ptv

PurpShell
PurpShell approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@PurpShell PurpShell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Auties00 Auties00 merged commit e24947e into WhiskeySockets:master Oct 16, 2023
1 check passed
@WakakaTz WakakaTz mentioned this pull request May 19, 2024
Open
@kamuridesu kamuridesu mentioned this pull request May 19, 2024
Closed
@WakakaTz WakakaTz mentioned this pull request May 21, 2024
Open
@kamuridesu kamuridesu mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaatt kaatt kaatt approved these changes

@Auties00 Auties00 Auties00 approved these changes

@PurpShell PurpShell PurpShell approved these changes

@souravkl11 souravkl11 souravkl11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brhenrique @whiskeysockets-bot @kaatt @Auties00 @PurpShell @souravkl11