Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS 13.4 support #29

Closed
Frityet opened this issue Jun 7, 2023 · 3 comments · Fixed by #30
Closed

macOS 13.4 support #29

Frityet opened this issue Jun 7, 2023 · 3 comments · Fixed by #30

Comments

@Frityet
Copy link
Contributor

Frityet commented Jun 7, 2023

game-porting-toolkit works flawlessly on macOS 13.3, just requiring the "Command line tools for XCode 15 beta". Whilst working on my pull request (#13), I backported it to macOS 13 to work on my machine, with the only change being the closure arguments for a SwiftUI view. Should I make a PR to introduce this change?

@Frityet
Copy link
Contributor Author

Frityet commented Jun 7, 2023

the error btw
/Users/frityet/Documents/Packages/Whisky/Whisky/Views/AppDBView.swift:20:33 Contextual closure type '(String) -> Void' expects 1 argument, but 2 were used in closure body

Fixed by

.onChange(of: search) { _, newValue  in

to

.onChange(of: search) { newValue  in

Which seems to still be present in the latest macOS

@DaveFlashNL
Copy link

DaveFlashNL commented Jun 8, 2023

whisky app itself will not run on ventura

downloaded from here: https://github.com/IsaacMarovitz/Whisky/releases/tag/pre-0.2.1

@palmerj
Copy link

palmerj commented Jun 20, 2023

Is it possible to actually run DX11/12 games on 13.4 though? I've just downloaded whisky 0.3.1 and can't get an DX11/12 games to run. I'm getting errors like the following with God of War (dx11)

preloader: Warning: failed to reserve range 0000000000010000-0000000000110000

and a stack trace:

Unhandled exception: divide by zero in 64-bit code (0x007ffa29fc53b0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants