Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Registry editor #13

Closed
wants to merge 292 commits into from
Closed

[WIP] Registry editor #13

wants to merge 292 commits into from

Conversation

Frityet
Copy link
Contributor

@Frityet Frityet commented Jun 7, 2023

Hey there!

I just wanted to make this draft PR for communication regarding this feature.

Furthermore, I was wondering, will this app target macOS 14 only? Or can I include my code that backports it to macOS 13? I can update if required

Thanks!

IsaacMarovitz and others added 5 commits June 9, 2023 17:03
* init Chinese localizable.strings

* update Chinese version

* fix

* update xcodeproj

* update zh-Hant

* add Drag and drop prompt as a localizable string

* fix empty line

* recover project.pbxproj
@Marsgames Marsgames mentioned this pull request Jun 9, 2023
7408647n and others added 20 commits June 9, 2023 18:42
* Add German translation

* Fix German translation
* feat: add Ukrainian localization

* Add Project file changes
add korean

Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
* New translations Localizable.strings (French)

* New translations Localizable.strings (Polish)

* New translations Localizable.strings (French)

* New translations Localizable.strings (Spanish)

* New translations Localizable.strings (Russian)

* Update source file Localizable.strings

* New translations Localizable.strings (Chinese Simplified)

* New translations Localizable.strings (Chinese Traditional)

* New translations Localizable.strings (French)

* New translations Localizable.strings (Chinese Simplified)

* New translations Localizable.strings (Chinese Traditional)

* New translations Localizable.strings (Chinese Simplified)

* New translations Localizable.strings (Chinese Traditional)

* New translations Localizable.strings (German)

* New translations Localizable.strings (Ukrainian)

* New translations Localizable.strings (Spanish)

* New translations Localizable.strings (Spanish)

* New translations Localizable.strings (Finnish)

* New translations Localizable.strings (Korean)
Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
* New translations Localizable.strings (Russian)

* New translations Localizable.strings (Korean)

* New translations Localizable.strings (Dutch)

* New translations Localizable.strings (Italian)
* Added Turkish, Portuguese, Chinese, Japanese localizations and improved German localizations

* Remove CN and German changes

* Add to Xcode

---------

Co-authored-by: Peek-a-Chuu <k@s-MacBook-Pro.fritz.box>
Co-authored-by: Isaac Marovitz <isaacryu@icloud.com>
Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
* Add bottle name validation

* Change view to original size

* Fix line length violation

* Replace NSLocalizedString usage

* Change warning text position

* Invert name validation logic

* Rewrite return message, as enum flags

* Update Localizable.strings

---------

Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
@JoshuaBrest
Copy link
Contributor

@Frityet Your PR was closed because of a problem with git LFS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet