Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to applications alert on first launch #36

Conversation

kavoye
Copy link
Contributor

@kavoye kavoye commented Jun 8, 2023

There are a few issues when opening the app from the folder it has been downloaded to, e.g. ~/Downloads

  1. Sparkle cannot update the application if it is launched from the folder where it has been downloaded.
  2. Dropping the .dmg file into the drop area has no effect if the app is not in the Applications folder. (This fixes issue Drag and Drop dmg #25.)

To address this issue, I have implemented a gentle alert for the user upon the first app launch, advising them to move the application to the Applications folder. This solution works seamlessly, and the user does not need to restart the application after clicking "Move to Applications" button.

Screenshot 2023-06-08 at 13 38 39

Whisky/AppDelegate.swift Outdated Show resolved Hide resolved
@IsaacMarovitz IsaacMarovitz merged commit c8e4b07 into Whisky-App:main Jun 8, 2023
1 check failed
@IsaacMarovitz IsaacMarovitz mentioned this pull request Jun 8, 2023
@kavoye kavoye deleted the feat/add-move-to-applications-folder-alert branch June 8, 2023 12:37
ohaiibuzzle pushed a commit to ohaiibuzzle/Whisky that referenced this pull request Jun 20, 2023
* chore: add .DS_Store to .gitignore

* fix: fix size of GPTInstallView

* feat: add move to applications alert on first Whisky launch

* chore: code refactoring

* chore: add localisation for alert

* Update Localizable.strings

* Update AppDelegate.swift

* Update GPT.swift

* Update AppDelegate.swift

---------

Co-authored-by: Isaac Marovitz <42140194+IsaacMarovitz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants