Remove @State and @Binding where not needed
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProgramItemView also doesn't use the Bottle it's passed (In fact, very little that uses class types needs Bindings)
…mport that's not needed
ohaiibuzzle
pushed a commit
to ohaiibuzzle/Whisky
that referenced
this pull request
Jun 20, 2023
* BottleRenameView doesn't need a Binding * BottleListEntry doesn't need a Binding * ProgramsView and ProgramItemView doesn't need a Binding ProgramItemView also doesn't use the Bottle it's passed (In fact, very little that uses class types needs Bindings) * Removes an instance of @State where it's not needed, and removes an import that's not needed * Removes some more instances where `@State` is used and not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, I've removed a bunch of instances where
@Stateor@Bindingwas used, but was not necessary.