-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After one location error location messages don't work #5215
Comments
could you please be a bit more precise, what do you mean by "location message screen"? The google place picker? What can only be solved by a reinstall? Adding locations as attachments/opening the google place picker? And are you using the play store build or a self-built version? |
The "Pick a place" screen that shows a map and below that a list of nearby places. A reinstall fixes the opening of that screen. Before reinstall I see it showing a short time before it closes. I use a self-built version with my own api key. |
if the api key is correct, maybe try to get a adb log, and see if there is some error message from the google place picker activity. I don't see any of these exceptions in the log: https://github.com/WhisperSystems/Signal-Android/blob/master/src/org/thoughtcrime/securesms/mms/AttachmentManager.java#L258 |
Your log shows |
Hmm, odd. I just checked, the API key is still listed as active at the Googe developers console. Next time I get this I'll post a general logcat output. |
Something strange I noticed today: Now when I checked the API key quota it shows 101 requests for today! I tried location sharing at most twice. |
Yes. (It looked a bit different on Marshmallow but it's the same dialog.) How many requests do you see for your API key? I did not realize there was any issue when I used the location feature so I didn't capture logs. Not my device so it's hard to debug more. |
Odd. Google lists the key as not used? Anyway, this time I made a complete log with catlog. I didn't find anything strange in it though. @cascheberg: I found this in the log:
Is there something wrong here?
|
@johanw666 |
I should have noticed that myself. Sorry I bothered you with it. Hmmm. When I removed the "Restrict usage to your Android apps (Optional)" option in the setting for the key, where I had it limited the use for org.thoughtcrime.securesms, it works again. Why? I have no idea. Now I also see the key is being used in the Google dashboard. |
Can someone with a self built Signal and Location API key test these steps:
Where exactly can you check the quota? Uuh... there doesn't seem to be a direct link. But if you go to https://console.developers.google.com/project/_/apiui/apiview/geolocation/quotas it should direct you to a page where you can select the project (which you use for Signal) and then the final url looks something like this https://console.developers.google.com/apis/api/placesandroid/usage?project=i-love-satan If it peaks I guess this also affects the official Signal but only moxie can see the quotas for that. |
Yes, it does spike for me.My guess would be that it is caused by the "Nearby Places" that keeps getting updated information from all the places where you sometimes stop or slow down the scrolling. To test this, logging could be built in this.mapView.getMapAsync(new OnMapReadyCallback() { BTW, I am thinking that the package name not being recognised might be caused by the patches I made to the Android installer with Lucky Patcher (it now ignores signatures so Ican install official and self-built versions on top of each other). |
I have location services set to device only, so no data is sent to Google. Sometimes, when the phone can't get a location, I get a popup that Signal wants to change the device settings to get a location through other means as well. When I select "never", the location message screen closes and after that it closes immediately after I try to open it. This can only be solved by a reinstall of Signal.
Last time this happened I didn't get a log, next time I will provide one.
The text was updated successfully, but these errors were encountered: