Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message sending should fail immediately when not connected. #1743

Closed
charlesmchen opened this issue Feb 10, 2017 · 3 comments
Closed

Message sending should fail immediately when not connected. #1743

charlesmchen opened this issue Feb 10, 2017 · 3 comments
Assignees

Comments

@charlesmchen
Copy link
Contributor

Repro:

  • Enter airplane mode.
  • Send message.

Expected: Message fails immediately.
Observed: Message sending is retried N times, then fails a few minutes later.

@charlesmchen charlesmchen added this to the Prioritized milestone Feb 10, 2017
@charlesmchen charlesmchen self-assigned this Feb 10, 2017
@riyapenn
Copy link

Perhaps, also include UIUX alert indicating not connected to the internet visible to the user prior to/as user types the message and device is offline.

@charlesmchen charlesmchen changed the title Message sending should fail immediately when no connection. Message sending should fail immediately when not connected. Feb 10, 2017
@footiecrazie
Copy link

@riyapenn, on iOS Apple recommends to make the network call and then handle failure.
https://developer.apple.com/library/content/documentation/NetworkingInternetWeb/Conceptual/NetworkingOverview/WhyNetworkingIsHard/WhyNetworkingIsHard.html#//apple_ref/doc/uid/TP40010220-CH13-SW3
https://developer.apple.com/library/content/documentation/NetworkingInternetWeb/Conceptual/NetworkingOverview/UnderstandingandPreparingfortheIPv6Transition/UnderstandingandPreparingfortheIPv6Transition.html#//apple_ref/doc/uid/TP40010220-CH213-SW25

@charlesmchen, when in airplane mode i can see 'Sending Failed. Tap to retry' text below the message. In addition the the message background text is greyed out. Observed this behaviour in latest code. Can you please suggest whether this issue is still valid?

@charlesmchen
Copy link
Contributor Author

I've tested a few scenarios and this now appears to be working properly. I'm closing.

@michaelkirk michaelkirk modified the milestone: Priority Ordered Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants