Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods 1.0 compatibility #1180

Closed
wants to merge 1 commit into from
Closed

CocoaPods 1.0 compatibility #1180

wants to merge 1 commit into from

Conversation

nicholas-lonsinger
Copy link

First time contributor checklist

Contributor checklist

  • I'm following the code, UI and style conventions
  • My commits are rebased on the latest master branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
    • Verification Server not responding, update not a code level change.
  • I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in my commit message

Description

CocoaPods 1.0 has been released and is now installed by default when
running ‘gem install cocoapods’. This updates the PodFile with the new
syntax and includes the changes to dependent files after running ‘pod
install’. FREEBIE

CocoaPods 1.0 has been released and is now installed by default when
running ‘gem install cocoapods’. This updates the PodFile with the new
syntax and includes the changes to dependent files after running ‘pod
install’. FREEBIE
@orta
Copy link
Contributor

orta commented May 14, 2016

I'd recommend switching the Podfile to look like this:

platform :ios, '8.0'

target 'Signal' do
  pod 'SignalServiceKit',           :git => 'https://github.com/WhisperSystems/SignalServiceKit.git'
  pod 'OpenSSL',                    '~> 1.0.208'
  pod 'PastelogKit',                '~> 1.3'
  pod 'FFCircularProgressView',     '~> 0.5'
  pod 'SCWaveformView',             '~> 1.0'
  pod 'DJWActionSheet'

  pod 'JSQMessagesViewController',  :git => 'https://github.com/WhisperSystems/JSQMessagesViewController', :commit => 'e5582fef8a6b3e35f8070361ef37237222da712b'

  target 'SignalTests' do
    inherit! :search_paths
  end
end

It better expresses the semantics of how you want the pods to connect to the Xcode targets, e.g. Signal has them linked, but the tests only know of their existence through the main target.

Plus you can remove the source as it's only using public CocoaPods/Specs pods

@nicholas-lonsinger
Copy link
Author

This is a duplicate of PR #1156 which has preferred semantics, so I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants