Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: authentication issues #182

Merged
merged 10 commits into from
Mar 14, 2022
Merged

FIX: authentication issues #182

merged 10 commits into from
Mar 14, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg added the bug Something isn't working label Mar 2, 2022
@Segelzwerg Segelzwerg self-assigned this Mar 2, 2022
@Segelzwerg Segelzwerg linked an issue Mar 2, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #182 (59d3014) into main (91a6fec) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 59d3014 differs from pull request most recent head c1c91ee. Consider uploading reports for the commit c1c91ee to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   94.93%   95.01%   +0.08%     
==========================================
  Files          27       28       +1     
  Lines         533      542       +9     
==========================================
+ Hits          506      515       +9     
  Misses         27       27              
Impacted Files Coverage Δ
whist/server/services/authentication.py 97.43% <ø> (ø)
whist/server/api/user/auth.py 100.00% <100.00%> (ø)
whist/server/database/access_token.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729bd4e...c1c91ee. Read the comment docs.

Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg marked this pull request as ready for review March 2, 2022 19:55
@Segelzwerg
Copy link
Contributor Author

Possible bug has been reported: PyCQA/bandit#842

@Segelzwerg Segelzwerg requested a review from iTitus March 6, 2022 11:23
@iTitus iTitus merged commit e66b58f into main Mar 14, 2022
@iTitus iTitus deleted the fix/authentication branch March 14, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: login with wrong name crashed
2 participants