Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Government occasionally shuts down #3

Closed
davatron5000 opened this issue Oct 9, 2013 · 780 comments
Closed

BUG: Government occasionally shuts down #3

davatron5000 opened this issue Oct 9, 2013 · 780 comments

Comments

@davatron5000
Copy link

@davatron5000 davatron5000 commented Oct 9, 2013

I noticed a bug over the past week or so and it seems reproducible:

  1. Go to U.S. Government.
  2. U.S. Government is shut down.

Expected results: Government should be working.

I'm unable to debug or propose a fix since there's not an open, transparent stack trace. Conflicting error messages are being thrown as well.

Hope you can resolve this soon. It would seem that the U.S. Government would value 100% uptime in order to be a reliable and trustworthy source for the rest of the world.

Thanks! Love this project and would like to continue using it.

@syropian
Copy link

@syropian syropian commented Oct 9, 2013

+1

@VinSpee
Copy link

@VinSpee VinSpee commented Oct 9, 2013

I can confirm that this is reproducible. Have you tried rebooting it?

@danveloper
Copy link

@danveloper danveloper commented Oct 9, 2013

👍

@mikehostetler
Copy link

@mikehostetler mikehostetler commented Oct 9, 2013

YES

@ceejayoz
Copy link

@ceejayoz ceejayoz commented Oct 9, 2013

We could probably reassign this back to 🇬🇧

@dcneiner
Copy link

@dcneiner dcneiner commented Oct 9, 2013

👍

@coogie
Copy link

@coogie coogie commented Oct 9, 2013

My local installation of Government seems to be running as normal.
There may be a problem with your configuration. Have you tried removing certain troublesome components and restarting?

@Gastove
Copy link

@Gastove Gastove commented Oct 9, 2013

My branch of the government is also shut down; can confirm that this is affecting more than just master.

@zachleat
Copy link

@zachleat zachleat commented Oct 9, 2013

Looks like someone may have inserted some malicious congresspeople, can we issue a Pull Request to remove?

@betacar
Copy link

@betacar betacar commented Oct 9, 2013

itcrowd

@morganestes
Copy link

@morganestes morganestes commented Oct 9, 2013

Love this project would like to continue using it.

This had me laughing out loud in the office. Thanks!

@RedWolves
Copy link

@RedWolves RedWolves commented Oct 9, 2013

I think it's time to fork a new repo again.

@erikroyall
Copy link

@erikroyall erikroyall commented Oct 9, 2013

Barack Obama, the lead developer should be assigned

@dajbelshaw
Copy link

@dajbelshaw dajbelshaw commented Oct 9, 2013

Could be a FOR loop issue with init.Republicans?

@ChrisMissal
Copy link

@ChrisMissal ChrisMissal commented Oct 9, 2013

If only contributors were allowed to rewrite history...

@pmgllc
Copy link

@pmgllc pmgllc commented Oct 9, 2013

The sysadmin says it's user error. Arrogant like all sysadmins.

@johnrengelman
Copy link

@johnrengelman johnrengelman commented Oct 9, 2013

👍

1 similar comment
@seanislegend
Copy link

@seanislegend seanislegend commented Oct 9, 2013

+1

@scottjehl
Copy link

@scottjehl scottjehl commented Oct 9, 2013

@johnboehner closed issue #3 as "#wontfix"

@dastels
Copy link

@dastels dastels commented Oct 9, 2013

Typical proprietary bloatware. Trash it and find a simpler, lighter weight alternative.

@tbwiii
Copy link

@tbwiii tbwiii commented Oct 9, 2013

👍

@jcsalterego
Copy link

@jcsalterego jcsalterego commented Oct 9, 2013

php strikes again

@sinker
Copy link

@sinker sinker commented Oct 9, 2013

Can we elevate this bug to critical?

@betacar
Copy link

@betacar betacar commented Oct 9, 2013

It's a ObamaCare exception trowed by Republican.all?

@dastels
Copy link

@dastels dastels commented Oct 9, 2013

Sounds like a new distributed approach might be worth trying.

@VinSpee
Copy link

@VinSpee VinSpee commented Oct 9, 2013

Looks like new code added to the getter on healthCare() is causing some of the constitution tests to fail.

@dastels
Copy link

@dastels dastels commented Oct 9, 2013

Rewrite, this time using logic programming.

@sao
Copy link

@sao sao commented Oct 9, 2013

+1

@zachleat
Copy link

@zachleat zachleat commented Oct 9, 2013

@VinSpee naw, @SupremeCourt verified tests are passing fine.

@jakerella
Copy link

@jakerella jakerella commented Oct 9, 2013

Confirmed, was able to reproduce. I think there may be a locking issue with congressional members.

@mattrayner
Copy link

@mattrayner mattrayner commented Jan 20, 2018

@sheldonrampton
Copy link

@sheldonrampton sheldonrampton commented Jan 20, 2018

I've done a root cause analysis. This bug stems from a race condition triggered when class inheritance passes public objects to a private subclass. It can be fixed by eliminating class-based inheritance, implementing rapid replication-on-demand from master to slave servers, and reverting commits during the past year that have been caused severe performance degradation.

@AyrA
Copy link

@AyrA AyrA commented Jan 20, 2018

This is so horribly broken it should be rewritten from scratch to be honest. The democracy class is horribly broken. Every time you submit a value, it no longer accepts inputs for 4 years. What the class does during that time is mostly disappointing and the outcome doesn't seems to be affected too much by the value you submit. I recommend rewriting the entire Democracy structure, or if the behaviour is intended (I hope not) at least rename it to Oligarchy to be less confusing

@nonprofitable
Copy link

@nonprofitable nonprofitable commented Jan 20, 2018

@hyperbolicTom
Copy link

@hyperbolicTom hyperbolicTom commented Jan 20, 2018

The bug is being given the codename Spectre Orange.
Something is causing massive amounts of erroneous code to be injected into the running system.
Currently the only known fix is to spank SO with a copy of Forbes Magazine.

@hyperbolicTom
Copy link

@hyperbolicTom hyperbolicTom commented Jan 20, 2018

Also the version number is 45, not 44

@naterkane
Copy link

@naterkane naterkane commented Jan 20, 2018

^ this is why semver is important.

Can someone please move this to the next sprint?

@jpettitt
Copy link

@jpettitt jpettitt commented Jan 20, 2018

Reading notes from @ wchurchill (prior PM on a parallel project) it appears to be related to it being "the worst system of government apart from all the others" and his research showed that a five minute conversation with the average user indicated they didn't understand the product.

Further market research by @ ripley suggests "nuke the entire site from orbit. It’s the only way to be sure." The North Korean office is working on the necessary technology.

@Kirk-H
Copy link

@Kirk-H Kirk-H commented Jan 23, 2018

The amount of technical debt in this application is astounding. I think you need to rip n' replace all services that interface with the original code base. The services seem totally disconnected from the intent of the original code authors and seem to be written to serve their own best interests and not the intentions of the original code.

I suggest you replace the entire framework with one that actually works together for the betterment of the application.

@emjayess
Copy link

@emjayess emjayess commented Jan 23, 2018

Needs more blockchain; call for papers open!

@mitar
Copy link

@mitar mitar commented Jan 23, 2018

I would advise against reimplementing from scratch because current code, with all its bugs, imperfections, and corruptions, have many checks and balances accumulated through centuries of use. Those checks prevent edge cases and adversarial attacks from internal and external sources or other corrupt or self-motivated processes. For many we even forgot that they exist, or we think that they do not exist anymore, because checks are preventing them from occurring. Sadly, current code is not well documented so it is impossible to reconstruct the list of all design and security decisions, use cases, bug reports, user experiences and general requirements which are present indirectly in the implementation.

See this tale for more background information: https://www.joelonsoftware.com/2000/04/06/things-you-should-never-do-part-i/

@MiguelCastillo
Copy link

@MiguelCastillo MiguelCastillo commented Jan 23, 2018

did someone leave a few console.log in the main module? It keeps writing tweets about nonsensical corrupted memory dumps.

@weshatheleopard
Copy link

@weshatheleopard weshatheleopard commented Jan 23, 2018

@mitar: the problem is that those checks and balances are, well, checking-and-balancing against old bugs that are no longer the case. For example, the institute of electors was implemented to solve the problem of XIX-century communication channels that were known for their low throughput, high latency and packet loss rates (see RFC 1149), and most consumer devices had trouble recognizing handwriting. No longer a problem: in year 2017, 99% of the user endpoints communicate over TCP/IP. Time to throw out the obsolete code, and implement at least direct democracy (although I would recommend moving on to XXI century and implement online/realtime democracy).

@hyperbolicTom
Copy link

@hyperbolicTom hyperbolicTom commented Jan 23, 2018

@mitar
Copy link

@mitar mitar commented Jan 24, 2018

the problem is that those checks and balances are, well, checking-and-balancing against old bugs that are no longer the case.

Really? I think if you read Plato's Republic, you can see that most cases of issues with governance were already there. Things like corrupt institutions and individuals, concentrations of power, nepotism. Heh, even Ponzi schemes still happen.

Time to throw out the obsolete code, and implement at least direct democracy (although I would recommend moving on to XXI century and implement online/realtime democracy).

Voting is just a very small part of whole governance application. Even story I linked before says:

A second reason programmers think that their code is a mess is that it is inefficient. The rendering code in Netscape was rumored to be slow. But this only affects a small part of the project, which you can optimize or even rewrite. You don’t have to rewrite the whole thing. When optimizing for speed, 1% of the work gets you 99% of the bang.

So yea, we can optimize/improve that 1% of the whole thing. But rewriting the whole application, this leads to failure. But a voting feature, there is definitely some improvement to be made. Collaboration in general. Real-time, massive, online.

@JonKernPA
Copy link

@JonKernPA JonKernPA commented Jan 25, 2018

@weshatheleopard
Copy link

@weshatheleopard weshatheleopard commented Jan 25, 2018

@mitar: I'm not suggesting we rewrite the entire application, I'm suggesting we stop using the obsolete library that has long known vulnerabilities. I suggest meritocracy.dll which, amongst many other benefits, has built-in protection against last year's widely discussed Trump side-channel attack.

@dijitlalchemist
Copy link

@dijitlalchemist dijitlalchemist commented Mar 11, 2018

for some reason wX + pY == (protection && (injury || death)) || (violation && (murder || death || kill)); is being rejected by the 2a.bor.pkg, anyone familiar with the lobby.of.lost.lives framework on Second Life?

@jpettitt
Copy link

@jpettitt jpettitt commented Mar 12, 2018

Full rewrites have a terrible track record, prior examples in other projects mostly haven't worked and have lead to had system crashes or major corruption. Given the investment in use training, test cases and documentation any major change it likely to be very disruptive to normal system operation. Far better to iterate towards a solution to identified problems by piloting ideas in the state level modules.

There are already "ranked choice / single transferable vote" models in test in several locales with positive results.

On the finance and accounting subsystems the "cut all the taxes" PR seems to have caused major disruption in Kansas and was largely reverted.

@orivasinzendesk
Copy link

@orivasinzendesk orivasinzendesk commented Jan 25, 2019

Unsure why this was closed, this seems to be happening again

@bjankord
Copy link

@bjankord bjankord commented Jan 25, 2019

Any ETA on when this feature will be back? It is critical to the livelihood of over 800k people. Now may be a good time to consider a rewrite of this functionality.

@ril3y
Copy link

@ril3y ril3y commented Jan 25, 2019

I think you have the wrong version. This should be a new issue under "fortyfive" However, as others have noted the version "fortyfive" is a major downgrade. It's development or lack thereof is under a whole new dev team that seems to be changing every few weeks. (Major turnover). Code is riddled with eligible gibberish. I would skip this version completely and wait for fortysix.

@deezzer
Copy link

@deezzer deezzer commented Jan 25, 2019

Seriously, there are much bigger fish to fry! But now I'm wondering if this is an issue about security or aesthetics? In other words, do we need a fleet of DevOps to build this static firewall or could this be done with just CSS borders to emphasize the layout of the page? Or maybe there's something else (that we'll never know) in upper management that's being displaced into this shutdown this time around.

@MiguelCastillo
Copy link

@MiguelCastillo MiguelCastillo commented Jan 25, 2019

I’d like to consider an emergency rollback to fourtyfour if at all possible. I know it is a real big lift, but it is a much more sustainable and scalable version. Or is there a way to disable or perhaps override fourtyfive?

@JonKernPA
Copy link

@JonKernPA JonKernPA commented Jan 25, 2019

@stimpy77
Copy link

@stimpy77 stimpy77 commented Jan 25, 2019

What I find most disconcerting is that this issue was raised at all under this component. This is not the WhiteHouse's responsibility. The separation of concerns has bled over between components, each component is doing way too much of other components' responsibilities. As a result no one seems to understand what component is supposed to do what.

This issue must be resolved in Capitol. The underlying problem is that Capitol is backlogged, putting out way too much more than what it takes in, resulting in a stack overflow fault. WhiteHouse v. fortyfive is using this as leverage, but ultimately Capitol hasn't worked properly in decades and it is getting worse logimarithically each year. Frankly I wonder if the whole thing should be rewritten.

@Sharondio
Copy link

@Sharondio Sharondio commented Jan 29, 2019

Looks like we have a patch for now.

@dankellett
Copy link

@dankellett dankellett commented Jan 29, 2019

Patch didn't fix the root cause, the bug will return without an RCA and it's appropriate fix.

@hyperbolicTom
Copy link

@hyperbolicTom hyperbolicTom commented Jan 29, 2019

@melvincarvalho
Copy link

@melvincarvalho melvincarvalho commented Mar 30, 2020

Patch didn't fix the root cause, the bug will return without an RCA and it's appropriate fix.

As a side-effect of the most recent patch, I believe, this error condition should now be obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.