Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Hardhat Helmet Sprites #403

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Conversation

Quantum-M
Copy link
Contributor

@Quantum-M Quantum-M commented Aug 24, 2020

About The Pull Request

Changes the hardhat helmet sprites to look less crappy (hopefully), adds a new green helmet, and updates the code for said hardhats a bit.

Also adds in safety helmets and mining helmets, and adds some of the safety helmets to the QMs, Atmos, and Electrical closets, and the mining one to the mining closets.

Why It's Good For The Game

Attempts to make helmets look nicer, along with giving them a object icon that isn't essentially the same as the on mob one.

image

image
Mining hardhat object sprite by thatangryminer

Changelog

馃啈 Quantum-M, thatangryminer
add: Green Hardhats, Safety Helmets, and Mining Helmets, and adds them to some of the lockers.
tweak: Updates sprites for hardhats.
code: Updated Hardhat code to not use the weird 0 and 1 numbers logic to look for relevant icon states.
/:cl:

@orange-vivid-planarian orange-vivid-planarian bot added Code Improvement Feature This Pull Request adds new functionality to the game Tweak Changes something in an already existing feature labels Aug 24, 2020
Copy link
Contributor

@MarkSuckerberg MarkSuckerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty darn good to me

Whitesands-Bot added a commit that referenced this pull request Aug 31, 2020
@SynnGraffkin
Copy link
Contributor

Is it just me or has Ian ALWAYS been spawning in with a helmet on now?

@Superyodeler
Copy link
Contributor

I was assuming people were giving him one every shift.

@SynnGraffkin
Copy link
Contributor

I've been the only one on shift and he had one already on multiple times.

@triplezeta
Copy link
Contributor

ian's hat is persistent

@dee-dubya
Copy link
Contributor

If Ian doesn't die, his hat persists between rounds.

If he does, he spawns as a puppy during the next round.

Whitesands-Bot added a commit that referenced this pull request Sep 3, 2020
@ADepressedPyroshark
Copy link
Contributor

I fucking hate these sprites because they are out of place. They go from the top down and NO OTHER SPRITE DOES THIS(citation needed). OR AT LEAST THE CLOTHING. THE FUCKING LIGHT MAKES ME THINK ITS A REALLY WEIRD MASK BECAUSE TOP DOWN IS SO OUT OF PLACE FOR THIS AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA. Other than that good job

@ADepressedPyroshark
Copy link
Contributor

Like, I mean when they are an item or whatever the worn sprites are fine its just change the item sprites PLEEEASE

@AsciiSquid
Copy link
Contributor

Gonna have to agree, worn sprites are fine but the item sprites (excluding the miner one) seem off compared to other hats for some reason.

@triplezeta
Copy link
Contributor

From experience with these in game,

The perspective of the helmets is odd. Putting it at a perspective that looks more similar to hats such as the berets or softcaps may help.
The palettes aren't to my liking. They feel very cartoony and generally aren't appealing to me. I'd prefer something a bit less saturated.
The headlamp lights are done in an odd way and don't fade away like the old ones did, leading to an odd appearance where the light will "cut off" abruptly.

Otherwise these are good

Whitesands-Bot added a commit that referenced this pull request Sep 4, 2020
@SynnGraffkin
Copy link
Contributor

The more I see these in game, the more it just feels extremely off to what we have prior. The cone of light especially feels way too different from just a lit bulb.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Sep 21, 2020
@Superyodeler Superyodeler merged commit e62119d into Whitesands13:master Sep 21, 2020
MarkSuckerberg pushed a commit to MarkSuckerberg/WaspStation-1.0 that referenced this pull request Nov 1, 2020
* Initial helmet stuff

* Re-Adds accidentally removed plasmaman paramedic helmet mob icon
MarkSuckerberg pushed a commit to MarkSuckerberg/WaspStation-1.0 that referenced this pull request Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Improvement Feature This Pull Request adds new functionality to the game Sprites Tweak Changes something in an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants