This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
AI Channel Fix and Borer Channel Change #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orange-vivid-planarian
bot
added
Fix
Maldaris
approved these changes
Oct 3, 2020
There was a problem hiding this comment.
I really wish these were defined in a central place, or config driven so that we could tweak them as-needed and actually see what channels are defined with what token. I'll make an issue to revisit that and find the right solution.
Otherwise this looks great. Well done.
|
Agreed. I should mention most of them are defined in DEFINES/radio.dm or DEFINES/say.dm, but some aren't. Like I know a and k are defined, but not where. |
MarkSuckerberg
approved these changes
Oct 4, 2020
|
Merging bugfix |
Whitesands-Bot
pushed a commit
that referenced
this pull request
Oct 4, 2020
MarkSuckerberg
pushed a commit
to MarkSuckerberg/WaspStation-1.0
that referenced
this pull request
Nov 1, 2020
Co-authored-by: Untrius <untrius@protonmail.com>
MarkSuckerberg
pushed a commit
to MarkSuckerberg/WaspStation-1.0
that referenced
this pull request
Nov 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The AI Private Channel token :o had stopped working, because the Borer Channel token was also set to :o and it took precedence over the AI Private Channel. I resolved this issue by changing the Borer Channel to :j.
There doesn't appear to be a single list with all the tokens in it. At the time of writing, it appears that :f, :j, :q, :w, and :z are still available. I believe :1 - :9 and :0 are also still available. It seems that the way to tell is to try to send a message on the channel, and if it returns the token, it's free. The example being if you say "test" using ":z", it'll say ":z test" back to you.
It also occurs to me that this can easily break if upstream decides to use :j for something else and we don't notice.
Channel output examples:
Headset using :o test
AI using :o test
Borer using :j test
Why It's Good For The Game
Bug fix: Issue #466
Changelog
馃啈
fix: AI channel :o works again
tweak: Borer channel changed from :o to :j
/:cl: