Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Added Recipient to PDA Message Input Box Title #511

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

untrius
Copy link
Member

@untrius untrius commented Oct 8, 2020

About The Pull Request

I passed the PDA list to msg_input() to pass the target's name to the title in stripped_input(). If there's more than one recipient in the target list, "Multiple PDAs" is displayed as the recipient. If both names together are too long, the title gets cut off. I'm ignoring this, since you can see enough to tell who you're messaging, assuming the sender hasn't decided to make their name/job combo excessively long.

One recipient example:
image

Multiple recipients example:
image

Title is too long example:
image

Why It's Good For The Game

Makes it less likely for your messages about mutiny against the captain, to get sent to the captain.

Changelog

馃啈
tweak: PDA send-message box says who the message is being sent to
/:cl:

@orange-vivid-planarian orange-vivid-planarian bot added Feature This Pull Request adds new functionality to the game Tweak Changes something in an already existing feature labels Oct 8, 2020
Whitesands-Bot added a commit that referenced this pull request Oct 9, 2020
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Oct 23, 2020
@Maldaris Maldaris merged commit e3ca32f into Whitesands13:master Oct 24, 2020
MarkSuckerberg pushed a commit to MarkSuckerberg/WaspStation-1.0 that referenced this pull request Nov 1, 2020
Co-authored-by: Untrius <untrius@protonmail.com>
MarkSuckerberg pushed a commit to MarkSuckerberg/WaspStation-1.0 that referenced this pull request Nov 1, 2020
@untrius untrius deleted the pda_add_recipient branch January 23, 2021 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature This Pull Request adds new functionality to the game Tweak Changes something in an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants