This repository has been archived by the owner on Sep 12, 2021. It is now read-only.
Optimize Stat panel subsystem #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizes stat panel code for better performance, including icon caching and removing some unnecessary processing Also fixes #53432 fix #53381 fix #53724 Changelog add: icons are back on alt clicks fix: horrible performance from alt clicking turfs with multiple objects tweak:browser should notify the SS when it's ready to receive data * Update statbrowser.html * Apply suggestions from code review Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> * hidden = TRUE * almost ready * Browser should notify when ready to receive data * Apply MSO's suggestions * reset cache if something in it gets deleted * Fix runtime * fix my stupid code * send href_token when adding admin tabs * fix an issue with cyborg suit topic Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
orange-vivid-planarian
bot
added
the
Fix
Whitesands-Bot
added a commit
that referenced
this pull request
Oct 16, 2020
MarkSuckerberg
approved these changes
Oct 21, 2020
Whitesands-Bot
pushed a commit
that referenced
this pull request
Oct 21, 2020
MarkSuckerberg
pushed a commit
to MarkSuckerberg/WaspStation-1.0
that referenced
this pull request
Nov 1, 2020
Optimizes stat panel code for better performance, including icon caching and removing some unnecessary processing Also fixes #53432 fix #53381 fix #53724 Changelog add: icons are back on alt clicks fix: horrible performance from alt clicking turfs with multiple objects tweak:browser should notify the SS when it's ready to receive data * Update statbrowser.html * Apply suggestions from code review Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> * hidden = TRUE * almost ready * Browser should notify when ready to receive data * Apply MSO's suggestions * reset cache if something in it gets deleted * Fix runtime * fix my stupid code * send href_token when adding admin tabs * fix an issue with cyborg suit topic Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> Co-authored-by: Couls <coul422@gmail.com> Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
MarkSuckerberg
pushed a commit
to MarkSuckerberg/WaspStation-1.0
that referenced
this pull request
Nov 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Optimizes stat panel code for better performance, including icon caching and removing some unnecessary processing
Port of tgstation/tgstation#53463
Why It's Good For The Game
Hopefully should fix/reduce the TIDI spikes we've been getting from the stat panel subsystem.
Changelog
🆑
fix: fixed some outstanding statpanel issues, including icons and processing lag.
/:cl: