Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover CameraModule with unit tests #234

Closed
2 of 19 tasks
hirako2000 opened this issue Apr 9, 2017 · 1 comment
Closed
2 of 19 tasks

Cover CameraModule with unit tests #234

hirako2000 opened this issue Apr 9, 2017 · 1 comment
Assignees
@hirako2000
Labels
MAINTAINANCE MODULE

Comments

@hirako2000
Copy link
Collaborator

CameraModule needs more comprehensive unit tests

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@hirako2000 hirako2000 self-assigned this Apr 9, 2017
stephenjgray pushed a commit that referenced this issue Apr 9, 2017
Add tests for camera module #234
ff1949e
stephenjgray pushed a commit that referenced this issue Apr 10, 2017
Improve camera module test following feedback, store reference to cus…
870d039 
…tomCameraModule.camera.native, use shorthand for params object #234
sasha240100 added a commit that referenced this issue Apr 11, 2017
@sasha240100
Merge pull request #235 from WhitestormJS/#234
8372dd6 
Add tests for camera module #234
@sasha240100
Copy link
Member

Merged #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirako2000 hirako2000

Labels
MAINTAINANCE MODULE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hirako2000 @sasha240100