Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage report. Unit testing #169

Open
7 of 22 tasks
sasha240100 opened this issue Mar 8, 2017 · 2 comments
Open
7 of 22 tasks

Increase coverage report. Unit testing #169

sasha240100 opened this issue Mar 8, 2017 · 2 comments

Comments

@sasha240100
Copy link
Member

sasha240100 commented Mar 8, 2017

Coverage on coveralls decreases. That's why we need to add more tests for Whitestorm.js API.
Those should include:

  • Components
    • AreaLight
    • Model
    • Text
    • Line
  • Modules
    • PostProcessorModule
    • VirtualMouseModule
    • DynamicGeometryModule
  • Controls
    • OrbitModule
Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question

Tested on: ###### --- Desktop - [ ] Chrome - [ ] Chrome Canary - [ ] Chrome dev-channel - [ ] Firefox - [ ] Opera - [ ] Microsoft IE - [ ] Microsoft Edge
--- Android
  • Chrome
  • Firefox
  • Opera
--- IOS
  • Chrome
  • Firefox
  • Opera
@sasha240100 sasha240100 added this to the V2 milestone Mar 8, 2017
@sasha240100 sasha240100 self-assigned this Mar 8, 2017
@sasha240100 sasha240100 added this to In priority in v2.2 Mar 10, 2017
@sasha240100 sasha240100 modified the milestones: v2.0.0-beta.6, v2.0.0-beta.7 Mar 13, 2017
@sasha240100 sasha240100 removed the JS label Mar 17, 2017
@sasha240100
Copy link
Member Author

@nickooms Any progress?

@hirako2000
Copy link
Collaborator

hirako2000 commented Mar 22, 2017

Looking at the existing tests, we have a few problems there:

  • Existing tests' spec don't describe properly (see example of proper description done the FogModule tests).
  • More assertions should be added across existing tests, not just those mentioned on this issue
  • The Structure should change, I suggest we bring tests closer to each src files (or maybe folder to keep src lists clean) as an incentive to add tests as we add code.
  • I suggest we raise an issue to bring structure to test folder, and simply encourage adding tests where missing to parts of code that gets modified. e.g I modify the TextureModule to add some param? I add test for the TextureModule if missing, then add my test to cover the new param.

Check tests during code review. Unless unreasonably difficult, I feel all PRs should include
appropriate tests (except for examples).

hirako2000 added a commit that referenced this issue Mar 22, 2017
sasha240100 added a commit that referenced this issue Mar 22, 2017
@sasha240100 sasha240100 moved this from High priority to Work in progress in v2.2 Mar 22, 2017
@sasha240100 sasha240100 modified the milestones: v2.0.0-beta.7, v2.0.0-beta.8 Mar 27, 2017
@sasha240100 sasha240100 moved this from Work in progress to Work in progress / Long-term in v2.2 Mar 27, 2017
@sasha240100 sasha240100 removed this from the v2.0.0-beta.9 milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2.2
Work in progress / Long-term
Development

No branches or pull requests

3 participants