-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase coverage report. Unit testing #169
Comments
@nickooms Any progress? |
hirako2000
added a commit
that referenced
this issue
Mar 22, 2017
hirako2000
added a commit
that referenced
this issue
Mar 22, 2017
hirako2000
added a commit
that referenced
this issue
Mar 22, 2017
hirako2000
added a commit
that referenced
this issue
Mar 22, 2017
hirako2000
added a commit
that referenced
this issue
Mar 22, 2017
Looking at the existing tests, we have a few problems there:
Check tests during code review. Unless unreasonably difficult, I feel all PRs should include |
hirako2000
added a commit
that referenced
this issue
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Coverage on coveralls decreases. That's why we need to add more tests for Whitestorm.js API.
Those should include:
AreaLight
Model
Text
Line
PostProcessorModule
VirtualMouseModule
DynamicGeometryModule
OrbitModule
Version:
Issue type:
Tested on:
###### --- Desktop - [ ] Chrome - [ ] Chrome Canary - [ ] Chrome dev-channel - [ ] Firefox - [ ] Opera - [ ] Microsoft IE - [ ] Microsoft Edge--- Android
--- IOS
The text was updated successfully, but these errors were encountered: