Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Cycle 1.1.21 Take 2 #90

Merged
merged 59 commits into from
Oct 7, 2018
Merged

Patch Cycle 1.1.21 Take 2 #90

merged 59 commits into from
Oct 7, 2018

Conversation

sirredbeard
Copy link

New, cleaner menu.

Much easier to administer.

Also works, unlike that other one.

Still needs a loop mechanism though.

@sirredbeard sirredbeard self-assigned this Oct 3, 2018
@sirredbeard
Copy link
Author

If you get a chance to look at looping the menu, great, if not I will return to it tomorrow.

The other bugs are out, this will be a better foundation for the menu, so we can add more package sets.

I think I can get rest of setup whiptailed by this or next week, plus a Ruby toolchain that has been requested.

while read choice
do
case $choice in
Explorer) explorerintegration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the case switch in bash is case sensitive... I cannot run the part here

@khuongduybui
Copy link

@sirredbeard regarding Yarn & n, I think it's fine if we keep Yarn and run sudo apt remove -y nodejs afterwards; just mark the whole NodeJS option as EXPERIMENTAL for now until we can come up with a more stable & reliable solution?

@sirredbeard
Copy link
Author

@khuongduybui The problem is what if people already installed nodejs via apt for another reason, not through wlinux-setup. This is an issue we run into with pip and python.

@khuongduybui
Copy link

@sirredbeard I don't have a strong opinion on this. If we decide to take yarn out of the main menu, can we at least put it in a secondary script somewhere?

@sirredbeard sirredbeard merged commit db3c5bb into master Oct 7, 2018
@sirredbeard sirredbeard deleted the patches2 branch October 7, 2018 01:37
@sirredbeard sirredbeard added Implemented Been there. Done that. and removed To Implement This is something we should implement. Undergoing Testing This has been implemented but is pending testing before release. labels Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implemented Been there. Done that.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants