-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Cycle 1.1.21 Take 2 #90
Conversation
If you get a chance to look at looping the menu, great, if not I will return to it tomorrow. The other bugs are out, this will be a better foundation for the menu, so we can add more package sets. I think I can get rest of setup whiptailed by this or next week, plus a Ruby toolchain that has been requested. |
linux_files/setup
Outdated
while read choice | ||
do | ||
case $choice in | ||
Explorer) explorerintegration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the case switch in bash is case sensitive... I cannot run the part here
@sirredbeard regarding Yarn & n, I think it's fine if we keep Yarn and run sudo apt remove -y nodejs afterwards; just mark the whole NodeJS option as EXPERIMENTAL for now until we can come up with a more stable & reliable solution? |
@khuongduybui The problem is what if people already installed nodejs via apt for another reason, not through wlinux-setup. This is an issue we run into with pip and python. |
@sirredbeard I don't have a strong opinion on this. If we decide to take yarn out of the main menu, can we at least put it in a secondary script somewhere? |
New, cleaner menu.
Much easier to administer.
Also works, unlike that other one.
Still needs a loop mechanism though.