Skip to content

Commit

Permalink
Revert "Allow APD data be accessed via thin client via Connection.get…
Browse files Browse the repository at this point in the history
…() (MDSplus#2620)"

This reverts commit d996b0c.
  • Loading branch information
WhoBrokeTheBuild committed Feb 23, 2024
1 parent c4ca59b commit 2f1ea31
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 33 deletions.
27 changes: 4 additions & 23 deletions java/mdsobjects/src/main/java/MDSplus/Connection.java
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,13 @@ public Data get(java.lang.String expr, Data args[]) throws MdsException
{
if (!checkArgs(args))
throw new MdsException(
"Invalid arguments: only scalars and arrays arguments can be passed to Connection.get()");
java.lang.String expandedExpr = "serializeout(`("+expr+"))";
Data serData = get(sockId, expandedExpr, args);
return Data.deserialize(serData.getByteArray());

"Invalid arguments: only scalars and arrays arguments can be passed to COnnection.get()");
return get(sockId, expr, args);
}

public Data get(java.lang.String expr) throws MdsException
{
java.lang.String expandedExpr = "serializeout(`("+expr+"))";
Data serData = get(sockId, expandedExpr, new Data[0]);
return Data.deserialize(serData.getByteArray());
return get(expr, new Data[0]);
}

public void put(java.lang.String path, java.lang.String expr, Data args[]) throws MdsException
Expand Down Expand Up @@ -150,19 +145,7 @@ public PutMany putMany()
{
return new PutManyInConnection();
}
public static void main(java.lang.String args[])
{
try {

MDSplus.Connection c = new MDSplus.Connection("localhost:8001");
c.openTree("test", -1);
System.out.println(c.get("anyapd"));
}catch(Exception exc)
{
System.out.println(exc);
}
}


////////// GetMany
class GetManyInConnection extends List implements GetMany
{
Expand Down Expand Up @@ -305,7 +288,5 @@ public void checkStatus(java.lang.String path) throws MdsException
throw new MdsException(retMsg.getString());
}
}



}
12 changes: 2 additions & 10 deletions mdsobjects/cpp/mdsipobjects.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -395,12 +395,8 @@ Data *Connection::get(const char *expr, Data **args, int nArgs)
}

lockLocal();
std::string expExpr("serializeout(`(");
expExpr +=expr;
expExpr += "))";
status = SendArg(sockId, 0, DTYPE_CSTRING_IP, nArgs + 1,
expExpr.size(), 0, 0, (char *)expExpr.c_str());
// std::string(expr).size(), 0, 0, (char *)expr);
std::string(expr).size(), 0, 0, (char *)expr);
if (STATUS_NOT_OK)
{
unlockLocal();
Expand Down Expand Up @@ -523,11 +519,7 @@ Data *Connection::get(const char *expr, Data **args, int nArgs)

if (mem)
FreeMessage(mem);

Data *deserData = deserialize(resData);
deleteData(resData);

return deserData;
return resData;
}

void Connection::put(const char *inPath, char *expr, Data **args, int nArgs)
Expand Down

0 comments on commit 2f1ea31

Please sign in to comment.