Config Directory Completeness #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that if the config directory already exists, the the default files associated with the usable, "I2P distribution" aren't copied over to the directory if they are missing. This includes 2 important sets of config files which weren't covered in the previous PR. These are the
hosts.txtfile and the "eepSite docroot." Thehosts.txtfile contains the default map of human-readable keys to cryptographic identifier values which comes with I2P and which forms the most basic part of it's naming service. This is a single file. The "eepSite docroot" contains the example hidden HTTP service which end-users may enable to host a static site as an I2P client application. This is 73 files, including 7 XML files for configuring jetty with non-leaking defaults, 21 translated HTML files containing identical text, 21 flags in.pngformat, 18 various other.pngfiles 3.cssfiles, 1 HTML template, arobots.txtand 1.icofile. It is quite a lot, but it is simply the stable default configuration for the recommended webserver.