Use toolchain from environment variables #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apnavik
approved these changes
Dec 24, 2018
apnavik
suggested changes
Dec 24, 2018
|
@apnavik Thanks for the review. I removed the lines you stated and I also removed the line for AR, because it also has a default value in make. |
kraj
pushed a commit
to kraj/Wi-FiTestSuite-Linux-DUT
that referenced
this pull request
Feb 9, 2019
Upstream-Status: Submitted [Wi-FiTestSuite#42] Signed-off-by: Adrian Friedli <adrian.friedli@husqvarnagroup.com> Signed-off-by: Ankit Navik <ankit.tarot@gmail.com>
|
Will this ever get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Poky Linux for our embedded devices. Poky sets the usual environment variables for selecting the toolchain. In this pull request I stop overriding already set environment variables and only set a default value where nothing is provided. This makes the build simpler.