Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сustom options.classes do not apply #335

Closed
cap-Bernardito opened this issue Sep 12, 2019 · 2 comments
Closed

Сustom options.classes do not apply #335

cap-Bernardito opened this issue Sep 12, 2019 · 2 comments

Comments

@cap-Bernardito
Copy link

cap-Bernardito commented Sep 12, 2019

function Headroom(elem, options) { options = options || {}; Object.assign(this, Headroom.options, options); Object.assign(this.classes, Headroom.options.classes, options.classes); ...
this.classes == Headroom.options.classes(default options.classes), but not options.classes(custom options.classes);

@cap-Bernardito cap-Bernardito changed the title Сustom options do not apply Сustom options.classes do not apply Sep 12, 2019
@WickyNilliams
Copy link
Owner

Gah, don't know how I missed this. Will add some tests for this and fix later

@WickyNilliams
Copy link
Owner

Messed up the initial release, but this is now on npm as v0.10.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants