Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][SNS logger] "Unable to reach Liveagent bot, it may be offline or disabled." did not throw an escalation failure event. #1333

Open
ear-dev opened this issue Oct 26, 2022 · 2 comments · May be fixed by WideChat/Apps.Dialogflow#180

Comments

@ear-dev
Copy link

ear-dev commented Oct 26, 2022

This error should have been caught as an escalation failure:

"Escalation": [
  	{"failed": [
  		{"failure_reason": "liveagent bot offline or disabled"} <- DF.app
          ]}

NOTE: I'm seeing this error correlated with sessions that are being closed by the df_bot due to no appName/token. However, it appears that the visitor is able to type into the composer, which triggers the DF fallback and attempts an escalation, which fails with this error. Therefore, this particular error seems to be the signature of a composer bug or race condition.

Our event logging will show an attempted escalation in this case, but not a failed escalation.

We should fix this event and consider adding another property to indicate something like 'composer_disabled_failure'

example:

Rocke.Chat Livechat ERROR: Failed to handover {"error":"","errorMessage":"Unable to reach Liveagent bot, it may be offline or disabled.","dialogflow_SessionID":"e5AnteBt2ZPeAFsRA","visitorDetails":{"id":"j38cTqdfPW6bvsKiF","token":"3c05e4fc5d17097ce5673712a2fdbe5212bff7b95d57b5b58cfcd65e3a5aefbf"},"targetDepartment":"hdgncTTn5YBrxyLLc"}
@ear-dev ear-dev created this issue from a note in Chatbot Client Replacement (Chatbot TODO) Oct 26, 2022
@ear-dev ear-dev changed the title [SNS logger] New event - "Unable to reach Liveagent bot, it may be offline or disabled." error seems to be the signature of a composer NOT disabled bug. [BUG][SNS logger] "Unable to reach Liveagent bot, it may be offline or disabled." did not throw an escalation failure event. Oct 26, 2022
@bhardwajaditya bhardwajaditya self-assigned this Nov 8, 2022
@bhardwajaditya bhardwajaditya moved this from Chatbot TODO to In progress in Chatbot Client Replacement Nov 8, 2022
@ear-dev
Copy link
Author

ear-dev commented Nov 15, 2022

@bhardwajaditya can you put some notes in here about your findings please, with a few links to the places in the code? Thank you...

@ear-dev ear-dev moved this from In progress to Chatbot TODO in Chatbot Client Replacement Nov 15, 2022
@Shailesh351 Shailesh351 moved this from Chatbot TODO to In progress in Chatbot Client Replacement Dec 8, 2022
@ear-dev
Copy link
Author

ear-dev commented Dec 8, 2022

Status: this is not actually a real event at all. We should not have tried to escalate, because in all cases we have seen, this is no appname/token, and the actually relevant event is 'chat_closed/df_bot'. Please verify that in cases like this we are indeed getting the proper close event, and that we are not sending an attempted escalation event.

@Shailesh351 Shailesh351 linked a pull request Dec 12, 2022 that will close this issue
@Shailesh351 Shailesh351 moved this from In progress to Under Review in Chatbot Client Replacement Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants