Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username (spotlight) search doesn’t function well, very slow. Long delay #622

Open
jaytat0 opened this issue Aug 13, 2019 · 2 comments · Fixed by #648 · May be fixed by #663
Open

Username (spotlight) search doesn’t function well, very slow. Long delay #622

jaytat0 opened this issue Aug 13, 2019 · 2 comments · Fixed by #648 · May be fixed by #663
Labels
from the field
Projects
UI issues and issues from the field

Comments

@jaytat0
Copy link

jaytat0 commented Aug 13, 2019

In the field at times this seemed like it wasn't working b/c it took so long
@jaytat0 jaytat0 created this issue from a note in UI issues and issues from the field (To do) Aug 13, 2019
@jaytat0 jaytat0 moved this from To do to In progress in UI issues and issues from the field Aug 13, 2019
@Shailesh351
Copy link
Collaborator

Shailesh351 commented Aug 18, 2019 •
edited
Loading

I tried to reproduce this issue, but search is working pretty fine with normal internet connection.

What I found is, when internet connection is not there(client socket connection is in connecting, authenticating, or disconnected state) it is showing loading circle which will last around 10-12 seconds.

What I propose is only make spotlight api call when socket connection is in connected state.

@Shailesh351 Shailesh351 mentioned this issue Aug 18, 2019
Merged
@jaytat0 jaytat0 moved this from In progress to To do in UI issues and issues from the field Aug 19, 2019
@jaytat0
Copy link
Author

jaytat0 commented Aug 19, 2019

@Shailesh351 can you please try reproducing this issue by setting the emulator to a bad connection?

@jaytat0 jaytat0 reopened this Aug 19, 2019
@Shailesh351 Shailesh351 moved this from To do to In progress in UI issues and issues from the field Aug 26, 2019
@Shailesh351 Shailesh351 linked a pull request Aug 26, 2019 that will close this issue
Open
@Shailesh351 Shailesh351 moved this from In progress to Under Review in UI issues and issues from the field Aug 26, 2019
@Shailesh351 Shailesh351 removed their assignment Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
from the field
Projects
UI issues and issues from the field
  
Under Review
Milestone
No milestone
2 participants
@jaytat0 @Shailesh351