[NEW] Set Close Chat Modal Message from Admin Setting #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKanakis
changed the title
|
@AlexanderKanakis I just merged your other PR which probably caused this new conflict.. can you fix please? sorry... thanks |
|
I tested this and it's working well. Thanks @AlexanderKanakis. @bhardwajaditya can you review please? Thanks... |
|
@AlexanderKanakis do you need to push new build files after your latest commit? Oh... I see... you included the build files in that commit..... gottit |
|
@AlexanderKanakis this feature does not work for me anymore. Did you lose something in your last commit? Can you test this please.... thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: WideChat/Rocket.Chat#1150
Related PRs: WideChat/Rocket.Chat#1185