Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Special Characters in Messages show in Unicode #155

Merged
merged 6 commits into from
Oct 5, 2022

Conversation

AlexanderKanakis
Copy link
Collaborator

@AlexanderKanakis AlexanderKanakis commented Oct 4, 2022

@ear-dev
Copy link

ear-dev commented Oct 4, 2022

@AlexanderKanakis I tested this and it looks good. We can merge after @Shailesh351 takes a quick look. Thanks.

@ear-dev ear-dev requested a review from csmith14 October 5, 2022 15:40
@csmith14
Copy link

csmith14 commented Oct 5, 2022

This looks like it doesn't address pasted/dropped text, as the handlers for those actions still use the parse function:

@ear-dev
Copy link

ear-dev commented Oct 5, 2022

This looks like it doesn't address pasted/dropped text, as the handlers for those actions still use the parse function:

I did just test cut and paste into a widget with this fix and it seemed to work fine. I used "I'm testing" because I know that apostrophe was a problem. Are there other good characters I can test?

@csmith14
Copy link

csmith14 commented Oct 5, 2022

Huh, okay maybe those handlers don't do exactly what their name implies?
Here's the character map used for replacements:

const escapeMap = {
	'&': '&',
	'<': '&lt;',
	'>': '&gt;',
	'"': '&quot;',
	'\'': '&#x27;',
	'`': '&#x60;',
};

@AlexanderKanakis
Copy link
Collaborator Author

New commit will deal the the issue @csmith14 found. Made sure that the text is still parsed upon submission, so it is clean.

@ear-dev
Copy link

ear-dev commented Oct 5, 2022

I tested the latest and it looks good to me.... @csmith14 ?

@ear-dev ear-dev merged commit 8d3a8c7 into develop Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] some characters not handled correctly in the client side widget
3 participants