Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP drain isn't 100% accurate #288

Closed
imsuck opened this issue Oct 4, 2022 · 3 comments · Fixed by #297
Closed

HP drain isn't 100% accurate #288

imsuck opened this issue Oct 4, 2022 · 3 comments · Fixed by #297
Labels
bug Something isn't working fixed-in-dev

Comments

@imsuck
Copy link

imsuck commented Oct 4, 2022

Describe the bug
Danser thought I failed in the replay but when I use osu! to view the replay it's a pass.

Files
replay
output

Logs
danser.log

Computer configuration:
Operating System: EndeavourOS x86_64 (kernel: 5.19.12-arch1-1)
CPU: Intel(R) Core(TM) i5-4210U
GPU: Mesa Intel(R) HD Graphics 4400 (HSW GT2)
Sound Card: I'm not sure

@Wieku
Copy link
Owner

Wieku commented Oct 7, 2022

I don't think I can fix that one. After analyzing replay data it should be a fail, even in osu.

If we look at this screenshot:
image

in osu, actually you get hit50:
image

But for some reason osu! decides to change it to hit300 because that bar disappears almost instantly.

@Wieku Wieku closed this as completed Oct 7, 2022
@Wieku Wieku added the wontfix This will not be worked on label Oct 7, 2022
@Wieku
Copy link
Owner

Wieku commented Oct 24, 2022

Left was an osu! replay bug that seems to be fixed in newest cuttingedge, but it turned out issue also lies on danser's side.

@Wieku Wieku reopened this Oct 24, 2022
@Wieku Wieku added bug Something isn't working and removed wontfix This will not be worked on labels Oct 24, 2022
@Wieku
Copy link
Owner

Wieku commented Oct 24, 2022

It's not yet pushed to dev branch but it appears to be fixed:

danser_2022-10-24_03-58-51.mp4

@Wieku Wieku mentioned this issue Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed-in-dev
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants