-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal offset does nothing in recordings #331
Comments
intended functionality, recordings should place hitsounds at exactly the right time no matter what, so offset issues are typically related to the map itself being off (based off what Wieku has said) |
Okay so it seems that recordings in Danser place the hitsounds exactly in the place osu! does, but that's also a problem. Well, I think it has to do with people perceiving offset differently. For me 0ms in osu! is unplayable cuz I would be tapping 30ms late trying to time the hitsounds to the music and it's why I have to use -30ms on every machine I've played osu! on, hence why I'm also hearing the hitsounds way too early on danser (so I guess this is a "me" problem?). Then there are people who have to play on positive offset for this exact reason. (+ Skins' hitsounds can also change the perceived timings of them) From my understanding universal offset is only shifting the song, right? If it works in Danser otherwise, I don't see how it couldn't be made work on recordings. I understand if it's too much to ask for such a nitpicky thing, but would be incredibly nice for my ears to have the option for it :D. So yeah it's not a crazy huge deal so it's fine. |
If you need -30ms on every hardware then I would assume so. Or there's a common hardware link (like terrible keyboard or mouse) which makes your ear accustomed to latency so no-latency then feels wrong. Global offset is used to offset hardware latency which doesn't happen in record mode. If there's an issue with the map itself, use Time/Offset -> Audio offset. But if you're intending to share the video it's best to keep offsets original (unless you see online offset when looking at map info in osu! client) |
"Global offset" means what here? If we're talking about osu!'s universal offset (and Danser's with that), that doesn't do anything for hardware latency, it shifts the song relative to hitsounds, so what does this mean?
And if there's an offset problem with the map itself, doing "Time/Offset -> Audio offset" will just move all of the sound including the song to an incorrect place, when only moving the song to the hitsounds would fix it. If this is still too much of a "me" problem then that's fine, but it would be a useful feature for some people. Cheers! |
At least since danser v0.7.0 not sure about older versions, universal offset has done nothing with recordings. To my ear, the hitsounds feel like they are a bit too early so I'd like to use an offset of -30ms which I also use in game. Tested with -300ms and 300ms, nothing changed. Is this behavior intended or simply an oversight?
Log
danser.log
Shouldn't be a hardware problem, this has been applicable on every system of mine.
The text was updated successfully, but these errors were encountered: