Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD encoding support #353

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

AMD encoding support #353

wants to merge 2 commits into from

Conversation

vipotaenko02
Copy link

Not sure if this will work perfectly but I will continue to contribute to this request. I know support for AMD hardware encoding was dropped, but at least knowing the risk in edge cases like low-end CPU this may help. And there is also an opened issue about AMD pro drivers on Linux, which may help encoding work better there (not sure though, for now I can only test Windows support, but eventually I'll get working on a Linux support too). For the time being, while support is experimental I will build a forked version with changes I made there. If anyone's interested, testing will be greatly helpful.

Adding correct changing of codec settings, not through custom settings, and provide readable parameters.
@vipotaenko02
Copy link
Author

vipotaenko02 commented Dec 27, 2023

For now the tasks are:

  • Rewrite ffmpeg download while building, because for now it downloads a version without needed encoders
  • Add encoder options, such as profile, etc
  • Thoroughly test encoder support to not be worse then software one
  • Make Linux support through the same encoders (if possible) or through vaapi

@vipotaenko02 vipotaenko02 changed the base branch from master to dev December 28, 2023 09:29
@Wieku
Copy link
Owner

Wieku commented Feb 26, 2024

@vipotaenko02 What's the status of this?

BTW The newest release of https://github.com/Wieku/FFmpeg-Builds should now support amf, can you test it?

Copy link
Owner

@Wieku Wieku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for import sorting it looks ok. I can merge it as soon as more granular control for qp is added (qp_i, qp_b, qp_p flags ig?)

"path/filepath"
"strings"

"github.com/wieku/danser-go/framework/env"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use gofmt instead of goimports for formatting. It looks better in general but for now I prefer to keep consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants