This repository has been archived by the owner on Aug 18, 2022. It is now read-only.
HTTP-related changes and support for *big* WAD generation. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add max HTTP retry count, max HTTP timeout and download progress bar for content downloads.
|
Very nice, thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a max retry count, a max timeout value and a download progress bar for each content.
Also, while generating the WAD package header, a simple check will be carried out to see if the calculated content data size value exceeds
U32_MAX. If it does,0xFFFFFFFFwill be set as the content data size. This fixes WAD package generation for very big titles, such as full DLCs from music games.In case you wonder why you should bother adding all the HTTP changes: I'm from a third world country and my connection is both unstable and slow. Before I made these changes, the script would suddenly stop whenever a connection problem arised.
PyNUSD helped me greatly while creating wad2bin, so I thought opening this PR this would return the favor in some kind of way. :)