Deleting note from ticket #12
Conversation
|
@ragesoss can you please review it for the issue WikiEducationFoundation/WikiEduDashboard#3502 . I'll be creating separate pr in the wikiedudashboard for the client side work |
|
@hardy1334 please include tests for this as well. There are some examples you can follow in the tickets_controller_spec. |
|
sure, will do it |
|
I've tested this in conjuction with WikiEducationFoundation/WikiEduDashboard#3870 and it's working smoothly. Nice work! I'd still like to have a spec included in the this PR. Once that is ready, I can merge this, and then you can update the other PR to include the newer version of TicketDispenser in the Gemfile.lock and then it ought to be clear to merge once code review is done. |
|
sure I'll add the test for it, and push that commit |
|
@ragesoss I have added spec for it can you please check it and merge it so that I make necessary changes in other pr |
|
@ragesoss In the gemfile.lock for the other pr, current version is 0.1.0 , so should I change it to 0.2.0 or 0.1.1 ? |
| require 'rails_helper' | ||
|
|
||
| describe TicketDispenser::Tickets::RepliesController, type: :request do | ||
| describe '#destroy' do |
There was a problem hiding this comment.
This is not standard Ruby indentation. Should be two spaces.
There was a problem hiding this comment.
I'll make the necessary changes
|
The version number is fine to leave as it is. The gemfile is locking it to the specific revision straight from git. You should update the bundle to this new revision as part of your PR in the other repo, now that it's merged here. |
With this, we will be able to delete notes on server side.