-
Notifications
You must be signed in to change notification settings - Fork 589
/
campaigns_controller_spec.rb
527 lines (451 loc) · 20.5 KB
/
campaigns_controller_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
# frozen_string_literal: true
require 'rails_helper'
describe CampaignsController, type: :request do
describe '#index' do
before do
Campaign.create(title: 'A wonderful campaign',
default_passcode: 'custom')
end
it 'renders a 200' do
get '/campaigns'
expect(response.status).to eq(200)
end
it 'renders the search results' do
get '/campaigns', params: { search: 'won' }
# Should return only one campaign which matches the search criteria
expect(response.body).to include('A wonderful campaign')
expect(response.body).not_to include('Spring 2015')
end
it 'renders the "No results found"' do
get '/campaigns', params: { search: 'xyz' }
expect(response.body).to include('No results found')
end
end
describe '#create' do
let(:user) { create(:user) }
let(:admin) { create(:admin) }
let(:title) { 'My New? Campaign 5!' }
let(:expected_slug) { 'my_new_campaign_5' }
let(:campaign_params) do
{ campaign: { title: title,
default_passcode: 'custom',
custom_default_passcode: 'ohai' } }
end
context 'when user is an admin' do
before do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(admin)
end
it 'creates new campaigns with custom passcodes' do
post '/campaigns', params: campaign_params
new_campaign = Campaign.last
expect(new_campaign.slug).to eq(expected_slug)
expect(new_campaign.default_passcode).to eq('ohai')
end
it 'creates a campaign user for the current user' do
post '/campaigns', params: campaign_params
expect(CampaignsUsers.last.user_id).to eq(admin.id)
end
it 'does not create duplicate titles' do
Campaign.create(title: title, slug: 'foo')
post '/campaigns', params: campaign_params
expect(Campaign.last.slug).to eq('foo')
end
it 'does not create duplicate slugs' do
Campaign.create(title: 'foo', slug: expected_slug)
post '/campaigns', params: campaign_params
expect(Campaign.last.title).to eq('foo')
end
end
context 'when user is not an admin and feature flag is off' do
before do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
allow(Features).to receive(:open_course_creation?).and_return(false)
end
it 'returns a 401 and does not create a campaign' do
post '/campaigns', params: campaign_params
expect(response.status).to eq(401)
expect(Campaign.count).to eq(1)
end
end
end
describe '#update' do
let(:user) { create(:user) }
let(:admin) { create(:admin) }
let(:campaign) { create(:campaign) }
let(:description) { 'My new campaign is the best campaign ever!' }
let(:campaign_params) { { slug: campaign.slug, description: description } }
let(:request_params) { { campaign: campaign_params, slug: campaign.slug } }
it 'returns a 401 if the user is not an admin and not an organizer of the campaign' do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
delete "/campaigns/#{campaign.slug}", params: request_params
expect(response.status).to eq(401)
end
it 'updates the campaign if the user is an organizer of the campaign' do
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
put "/campaigns/#{campaign.slug}", params: request_params
expect(response.status).to eq(302) # redirect to /overview
expect(campaign.reload.description).to eq(description)
end
it 'updates the campaign if the user is an admin' do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(admin)
put "/campaigns/#{campaign.slug}", params: request_params
expect(response.status).to eq(302) # redirect to /overview
expect(campaign.reload.description).to eq(description)
end
end
describe '#destroy' do
let(:user) { create(:user) }
let(:admin) { create(:admin) }
let(:campaign) { create(:campaign) }
let(:request_params) { { slug: campaign.slug } }
it 'returns a 401 if the user is not an admin and not an organizer of the campaign' do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
delete "/campaigns/#{campaign.slug}", params: request_params
expect(response.status).to eq(401)
expect(Campaign.find_by(slug: campaign.slug)).not_to be_nil
end
it 'deletes the campaign if the user is a campaign organizer' do
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
delete "/campaigns/#{campaign.slug}", params: request_params
expect(response.status).to eq(302) # redirect to /campaigns
expect(Campaign.find_by(slug: campaign.slug)).to be_nil
end
end
describe '#add_organizer' do
let(:user) { create(:user) }
let(:admin) { create(:admin) }
let(:campaign) { create(:campaign) }
it 'returns a 401 if the user is not an admin and not an organizer of the campaign' do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
request_params = { slug: campaign.slug, username: 'MusikAnimal' }
put "/campaigns/#{campaign.slug}/add_organizer", params: request_params
expect(response.status).to eq(401)
expect(Campaign.find_by(slug: campaign.slug)).not_to be_nil
end
it 'adds the given user as an organizer of the campaign '\
'if the current user is a campaign organizer' do
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
user2 = create(:user, username: 'MusikAnimal')
request_params = { slug: campaign.slug, username: user2.username }
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
put "/campaigns/#{campaign.slug}/add_organizer", params: request_params
expect(response.status).to eq(302) # redirect to /overview
expect(CampaignsUsers.last.user_id).to eq(user2.id)
end
end
describe '#remove_organizer' do
let(:user) { create(:user) }
let(:user2) { create(:user, username: 'user2') }
let(:campaign) { create(:campaign) }
let(:request_params) { { slug: campaign.slug, id: organizer.user_id } }
let(:organizer) do
create(:campaigns_user, user_id: user2.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
end
it 'returns a 401 if the user is not an admin and not an organizer of the campaign' do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
put "/campaigns/#{campaign.slug}/remove_organizer", params: request_params
expect(response.status).to eq(401)
expect(CampaignsUsers.find_by(id: organizer.id)).not_to be_nil
end
it 'removes the given organizer from the campaign '\
'if the current user is a campaign organizer' do
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
put "/campaigns/#{campaign.slug}/remove_organizer", params: request_params
expect(response.status).to eq(302) # redirect to /overview
expect(CampaignsUsers.find_by(id: organizer.id)).to be_nil
end
end
describe '#remove_course' do
let(:user) { create(:user) }
let(:campaign) { create(:campaign) }
let(:course) { create(:course) }
let(:request_params) { { slug: campaign.slug, course_id: course.id } }
let!(:campaigns_course) do
create(:campaigns_course, campaign_id: campaign.id,
course_id: course.id)
end
it 'returns a 401 if the user is not an admin and not an organizer of the campaign' do
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
put "/campaigns/#{campaign.slug}/remove_course", params: request_params
expect(response.status).to eq(401)
expect(CampaignsCourses.find_by(id: campaigns_course.id)).not_to be_nil
end
it 'removes the course from the campaign if the current user is a campaign organizer' do
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
put "/campaigns/#{campaign.slug}/remove_course", params: request_params
expect(response.status).to eq(302) # redirect to /overview
expect(CampaignsCourses.find_by(id: campaigns_course.id)).to be_nil
end
end
describe '#users.json' do
let(:course) { create(:course) }
let(:campaign) { create(:campaign) }
let(:student) { create(:user) }
let(:instructor) { create(:user, username: 'Dr. Instructor') }
before do
campaign.courses << course
create(:courses_user, course_id: course.id, user_id: student.id,
role: CoursesUsers::Roles::STUDENT_ROLE)
create(:courses_user, course_id: course.id, user_id: instructor.id,
role: CoursesUsers::Roles::INSTRUCTOR_ROLE)
end
it 'returns list of students and instructors' do
get "/campaigns/#{campaign.slug}/users", params: { format: :json }
expect(response.body).to include(student.username)
expect(response.body).to include('Editor')
expect(response.body).to include(instructor.username)
expect(response.body).to include('Facilitator')
expect(response.body).to include(course.slug)
expect(response.body).to include(campaign.slug)
end
end
describe '#assignments.json' do
let(:course) { create(:course) }
let(:campaign) { create(:campaign) }
let(:student) { create(:user) }
let(:article) { create(:article, title: 'Selfie') }
before do
campaign.courses << course
create(:assignment, course: course, user: student, article_title: 'Music',
role: Assignment::Roles::ASSIGNED_ROLE)
create(:assignment, course: course, user: student, article_title: 'Selfie',
article: article, role: Assignment::Roles::REVIEWING_ROLE)
end
it 'returns list of students and instructors' do
get "/campaigns/#{campaign.slug}/assignments", params: { format: :json }
expect(response.body).to include(student.username)
expect(response.body).to include('Editing')
expect(response.body).to include('Reviewing')
expect(response.body).to include(course.slug)
expect(response.body).to include(campaign.slug)
expect(response.body).to include(article.title)
expect(response.body).to include('Music')
end
end
describe '#students' do
let(:course) { create(:course) }
let(:campaign) { create(:campaign) }
let(:student) { create(:user) }
before do
login_as build(:user)
campaign.courses << course
create(:courses_user, course_id: course.id, user_id: student.id,
role: CoursesUsers::Roles::STUDENT_ROLE)
end
after do
FileUtils.remove_dir('public/system/analytics')
end
context 'without "course" option' do
let(:request_params) { { slug: campaign.slug, format: :csv } }
it 'returns a csv of student usernames' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/students", params: request_params
expect(response.body).to include('file is being generated')
get "/campaigns/#{campaign.slug}/students", params: request_params
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include(student.username)
end
end
context 'with "course" option' do
let(:request_params) { { slug: campaign.slug, course: true, format: :csv } }
it 'returns a csv of student usernames with course slugs' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/students", params: request_params
expect(response.body).to include('file is being generated')
get "/campaigns/#{campaign.slug}/students", params: request_params
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include(student.username)
expect(csv).to include(course.slug)
end
end
end
describe '#instructors' do
let(:course) { create(:course) }
let(:campaign) { create(:campaign) }
let(:instructor) { create(:user) }
before do
login_as instructor
campaign.courses << course
create(:courses_user, course_id: course.id, user_id: instructor.id,
role: CoursesUsers::Roles::INSTRUCTOR_ROLE)
end
after do
FileUtils.remove_dir('public/system/analytics')
end
context 'without "course" option' do
let(:request_params) { { slug: campaign.slug, format: :csv } }
it 'returns a csv of instructor usernames' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/instructors", params: request_params
expect(response.body).to include('file is being generated')
get "/campaigns/#{campaign.slug}/instructors", params: request_params
follow_redirect!
expect(response.body).to include(instructor.username)
end
end
context 'with "course" option' do
let(:request_params) { { slug: campaign.slug, course: true, format: :csv } }
it 'returns a csv of instructor usernames with course slugs' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/instructors", params: request_params
expect(response.body).to include('file is being generated')
get "/campaigns/#{campaign.slug}/instructors", params: request_params
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include(instructor.username)
expect(csv).to include(course.slug)
end
end
end
describe '#courses' do
let(:course) { create(:course, user_count: 1) }
let(:campaign) { create(:campaign) }
let(:instructor) { create(:user) }
let(:request_params) { { slug: campaign.slug, format: :csv } }
before do
login_as instructor
campaign.courses << course
create(:courses_user, course_id: course.id, user_id: instructor.id,
role: CoursesUsers::Roles::INSTRUCTOR_ROLE)
end
after do
FileUtils.remove_dir('public/system/analytics')
end
it 'returns a csv of course data' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/courses", params: request_params
get "/campaigns/#{campaign.slug}/courses", params: request_params
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include(course.slug)
expect(csv).to include(course.title)
expect(csv).to include(course.school)
end
it 'cleans up the files afterwards' do
# This normally happens long afterwards, but in test mode
# sidekiq will execute all jobs immediately, so the file
# will be created and immediately deleted.
expect(CsvCleanupWorker).to receive(:perform_at).and_call_original
get "/campaigns/#{campaign.slug}/courses", params: request_params
expect(response.body).to include('file is being generated')
end
end
describe 'CSV actions' do
let(:wikidata) { Wiki.get_or_create(language: nil, project: 'wikidata') }
let(:course) { create(:course) }
let(:another_course) { create(:course, home_wiki: wikidata, slug: 'campaign/acourse') }
let(:campaign) { create(:campaign) }
let(:article) { create(:article) }
let(:user) { create(:user) }
let!(:revision) { create(:revision, article: article, user: user, date: course.start + 1.hour) }
let(:request_params) { { slug: campaign.slug, format: :csv } }
before do
stub_wiki_validation
login_as(user)
campaign.courses.push course, another_course
create(:courses_user, course: course, user: user)
end
after do
FileUtils.remove_dir('public/system/analytics')
end
it 'return a csv of article data' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/articles_csv", params: request_params
get "/campaigns/#{campaign.slug}/articles_csv", params: request_params
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include(course.slug)
expect(csv).to include(article.title)
end
it 'return a csv of revision data' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/revisions_csv", params: request_params
get "/campaigns/#{campaign.slug}/revisions_csv", params: request_params
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include(course.slug)
expect(csv).to include(article.title)
expect(csv).to include('references_added')
end
it 'returns a csv of wikidata' do
expect(CsvCleanupWorker).to receive(:perform_at)
get "/campaigns/#{campaign.slug}/wikidata.csv"
get "/campaigns/#{campaign.slug}/wikidata.csv"
follow_redirect!
csv = response.body.force_encoding('utf-8')
expect(csv).to include('course name,claims created')
end
end
describe '#overview' do
let(:user) { create(:user) }
let(:campaign) { create(:campaign, description: 'New description') }
before do
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
get "/campaigns/#{campaign.slug}/overview", params: { slug: campaign.slug }
end
it 'renders 200' do
expect(response.status).to eq(200)
end
it 'shows the right campaign' do
expect(response.body).to include(campaign.title)
end
it 'shows properties of the campaign' do
expect(response.body).to include(campaign.description)
end
end
describe '#programs' do
let(:course) { create(:course) }
let(:course2) { create(:course, title: 'course2', slug: 'foo/course2') }
let(:campaign) { create(:campaign) }
before do
campaign.courses << course << course2
get "/campaigns/#{campaign.slug}/programs", params: { slug: campaign.slug }
end
it 'renders 200' do
expect(response.status).to eq(200)
end
it 'shows the right campaign' do
expect(response.body).to include(campaign.title)
end
it 'lists the programs for the given campaign' do
expect(response.body).to include(course.title)
expect(response.body).to include(course2.title)
expect(response.body).to include(course.school)
expect(response.body).to include(course.term)
end
it 'shows a remove button for the programs if the user is an organizer or admin' do
# don't show it if they are not an organizer or admin
expect(response.body).not_to include(I18n.t('assignments.remove'))
# when they are an organizer...
user = create(:user)
create(:campaigns_user, user_id: user.id, campaign_id: campaign.id,
role: CampaignsUsers::Roles::ORGANIZER_ROLE)
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user)
get "/campaigns/#{campaign.slug}/programs", params: { slug: campaign.slug }
expect(response.body).to include(I18n.t('assignments.remove'))
# when they are an admin...
admin = create(:admin)
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(admin)
get "/campaigns/#{campaign.slug}/programs", params: { slug: campaign.slug }
expect(response.body).to include(I18n.t('assignments.remove'))
end
it 'searches title, school, and term of campaign courses' do
request_params = { slug: campaign.slug, courses_query: course.title }
get "/campaigns/#{campaign.slug}/programs", params: request_params
expect(response.body).to include(course.title)
end
end
end