Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When weeks are deleted from a Timeline, the order may no longer be sequential #1996

Open
ragesoss opened this issue Sep 18, 2018 · 4 comments

Comments

@ragesoss
Copy link
Member

The result is that if a week is deleted and it's not the last week, and then a new week is added, the new week may not be at the end of the timeline.

I think this can be handled client-side, by recalculating the order attribute of the weeks whenever a week is added. That way, when the timeline is saved with the new week, the updated order will get persisted to the server, without worrying about any additional server-side logic.

@Cressence
Copy link
Contributor

@ragesoss can i work on this?

@ragesoss
Copy link
Member Author

Please do!

@faithngetich
Copy link
Contributor

@ragesoss has this issue been addressed yet? If not, I'd like to work on it.

@ragesoss
Copy link
Member Author

I think this is still an issue. Go for it. I suggest replicating the issue first to confirm that it really is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants