Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change assignment start to match course start #2713

Open
ragesoss opened this issue Apr 2, 2019 · 2 comments
Open

Cannot change assignment start to match course start #2713

ragesoss opened this issue Apr 2, 2019 · 2 comments
Labels

Comments

@ragesoss
Copy link
Member

ragesoss commented Apr 2, 2019

There appears to be more trouble after the recent tweaks to timezone handling.

For this course, the start date shows April 1, but is actually April 2, and you can selected April 2 as the timeline start, but it ends up actually being April 3:

{"course":{"id":13322,"title":"Gender in Cross-Cultural Perspective","description":"The Wikipedia portion of this course requires that students apply what they have learned from our course material to Wikipedia content critically as readers and editors. The larger classroom course spans the Spring semester, but their Wikipedia assignment for this course is in the last three weeks of the course.","start":"2019-04-02T00:00:00.000Z","end":"2019-05-21T23:59:59.000Z","school":"Cottey College","subject":"Anthropology and Gender Studies","slug":"Cottey_College/Gender_in_Cross-Cultural_Perspective_(Spring_2019)","url":"https://en.wikipedia.org/wiki/Wikipedia:Wiki_Ed/Cottey_College/Gender_in_Cross-Cultural_Perspective_(Spring_2019)","submitted":true,"expected_students":7,"timeline_start":"2019-04-03T00:00:00.000Z","timeline_end":"2019-05-21T23:59:59.000Z","day_exceptions":"","weekdays":"0010100","no_day_exceptions":true,"updated_at":"2019-04-02T20:10:49.000Z","string_prefix":"courses","use_start_and_end_times":false,"type":"ClassroomProgramCourse","home_wiki":{"id":1,"language":"en","project":"wikipedia"},"character_sum":0,"upload_count":0,"uploads_in_use_count":0,"upload_usages_count":0,"cloned_status":null,"flags":{"timeline_enabled":true,"wiki_edits_enabled":true,"edit_settings":{"wiki_course_page_enabled":true,"assignment_edits_enabled":false,"enrollment_edits_enabled":true},"update_logs":{"125":{"start_time":"2019-04-02T18:40:34.476+00:00","end_time":"2019-04-02T18:40:34.572+00:00"},"126":{"start_time":"2019-04-02T18:50:38.531+00:00","end_time":"2019-04-02T18:50:38.612+00:00"},"127":{"start_time":"2019-04-02T19:00:51.705+00:00","end_time":"2019-04-02T19:00:51.823+00:00"},"128":{"start_time":"2019-04-02T19:10:52.987+00:00","end_time":"2019-04-02T19:10:53.085+00:00"},"129":{"start_time":"2019-04-02T19:21:10.184+00:00","end_time":"2019-04-02T19:21:10.280+00:00"},"130":{"start_time":"2019-04-02T19:30:38.980+00:00","end_time":"2019-04-02T19:30:39.095+00:00"},"131":{"start_time":"2019-04-02T19:40:44.262+00:00","end_time":"2019-04-02T19:40:44.373+00:00"},"132":{"start_time":"2019-04-02T19:51:05.937+00:00","end_time":"2019-04-02T19:51:06.034+00:00"},"133":{"start_time":"2019-04-02T20:00:33.525+00:00","end_time":"2019-04-02T20:00:33.654+00:00"},"134":{"start_time":"2019-04-02T20:10:48.901+00:00","end_time":"2019-04-02T20:10:49.038+00:00"}},"average_update_delay":601},"level":"Advanced Undergrad","private":false,"closed?":false,"training_library_slug":"students","timeline_enabled":true,"home_wiki_edits_enabled":true,"wiki_edits_enabled":true,"assignment_edits_enabled":false,"wiki_course_page_enabled":true,"enrollment_edits_enabled":true,"account_requests_enabled":false,"term":"Spring 2019","legacy":false,"ended":false,"published":false,"closed":false,"enroll_url":"https://dashboard.wikiedu.org/courses/Cottey_College/Gender_in_Cross-Cultural_Perspective_(Spring_2019)/enroll/","created_count":"0","edited_count":"0","edit_count":"0","student_count":0,"trained_count":0,"word_count":"0","view_count":"0","character_sum_human":"0","updates":{"average_delay":601,"last_update":{"start_time":"2019-04-02T20:10:48.901+00:00","end_time":"2019-04-02T20:10:49.038+00:00"}},"passcode":"****","canUploadSyllabus":false}}
@ragesoss ragesoss added the bug label Apr 2, 2019
@khyatisoneji
Copy link
Member

Hi @ragesoss can you please give some pointers to how to import this course json? Also is this a beginner level bug or an advanced level issue

@ragesoss
Copy link
Member Author

@khyatisoneji you can get the json for any give course by going to the course.json route for it, for example, in this case: https://dashboard.wikiedu.org/courses/Cottey_College/Gender_in_Cross-Cultural_Perspective_(Spring_2019)/course.json

The issue should be replicable if you save a course in your database with the start, end and timeline start/end dates from the JSON, and then also set your computer to western timezone like UTC-7. Then you can visit it on the frontend and try to change the dates.

This probably only affects the wiki_education: true configuration, because the frontend behaves differently based on whether exact times or just dates are used for setting the start/end.

It's not a beginner level bug, but I think you could solve it. The main thing will be to solve it in a way that works for users in any timezone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants