Merge pull request #2301 from WikiWatershed/ki/adjust-compare-view-pa…

…gination Show compare pagination buttons only if > 5 scenarios Connects #2242
WikiWatershed · Oct 2, 2017 · 08d314a · 08d314a
2 parents 95a06ea + 9572763
commit 08d314a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/src/mmw/js/src/compare/models.js b/src/mmw/js/src/compare/models.js
@@ -7,7 +7,7 @@ var _ = require('lodash'),
 
 var CHART = 'chart',
     TABLE = 'table',
-    MIN_VISIBLE_SCENARIOS = 3,
+    MIN_VISIBLE_SCENARIOS = 5,
     CHART_AXIS_WIDTH = 82,
     COMPARE_COLUMN_WIDTH = 134;
 

diff --git a/src/mmw/js/src/compare/views.js b/src/mmw/js/src/compare/views.js
@@ -66,16 +66,21 @@ var CompareWindow2 = modalViews.ModalBaseView.extend({
             prevButton = this.ui.prevButton,
             nextButton = this.ui.nextButton;
 
-        if (i < 1) {
-            prevButton.removeClass('active');
+        if (total <= minScenarios) {
+            prevButton.hide();
+            nextButton.hide();
         } else {
-            prevButton.addClass('active');
-        }
+            if (i < 1) {
+                prevButton.removeClass('active');
+            } else {
+                prevButton.addClass('active');
+            }
 
-        if (i + minScenarios >= total) {
-            nextButton.removeClass('active');
-        } else {
-            nextButton.addClass('active');
+            if (i + minScenarios >= total) {
+                nextButton.removeClass('active');
+            } else {
+                nextButton.addClass('active');
+            }
         }
     },