Skip to content

Commit

Permalink
Remove port 8080 from firewall rules
Browse files Browse the repository at this point in the history
  • Loading branch information
tnation14 committed Aug 17, 2017
1 parent 170f686 commit ce5c406
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions deployment/cfn/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
EC2_INSTANCE_TYPES,
GRAPHITE,
HTTP,
HTTP_ALT,
HTTPS,
POSTGRESQL,
REDIS,
Expand Down Expand Up @@ -332,7 +331,7 @@ def create_security_groups(self):
IpProtocol='tcp', CidrIp=ALLOW_ALL_CIDR, FromPort=p,
ToPort=p
)
for p in [HTTP, HTTP_ALT, HTTPS]
for p in [HTTP, HTTPS]
],
Tags=self.get_tags(Name=app_server_security_group_name)
))
Expand Down
1 change: 0 additions & 1 deletion deployment/cfn/utils/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
GRAPHITE = 2003
GRAPHITE_WEB = 8080
HTTP = 80
HTTP_ALT = 8080
HTTPS = 443
KIBANA = 5601
POSTGRESQL = 5432
Expand Down
5 changes: 2 additions & 3 deletions deployment/cfn/vpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
ALLOW_ALL_CIDR,
EC2_INSTANCE_TYPES,
HTTP,
HTTP_ALT,
HTTPS,
VPC_CIDR
)
Expand Down Expand Up @@ -254,14 +253,14 @@ def nat_security_group(self):
IpProtocol='tcp', CidrIp=VPC_CIDR,
FromPort=p, ToPort=p
)
for p in [HTTP, HTTP_ALT, HTTPS]
for p in [HTTP, HTTPS]
],
SecurityGroupEgress=[
ec2.SecurityGroupRule(
IpProtocol='tcp',
CidrIp=ALLOW_ALL_CIDR,
FromPort=port, ToPort=port
) for port in [HTTP, HTTP_ALT, HTTPS]
) for port in [HTTP, HTTPS]
],
Tags=self.get_tags(Name=nat_security_group_name)), # NOQA
'NATSecurityGroup'
Expand Down

0 comments on commit ce5c406

Please sign in to comment.