Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geoprocessing API: Create home for new endpoints #2184

Closed
arottersman opened this issue Aug 24, 2017 · 1 comment
Closed

Geoprocessing API: Create home for new endpoints #2184

arottersman opened this issue Aug 24, 2017 · 1 comment

Comments

@arottersman
Copy link

arottersman commented Aug 24, 2017

  • Determine...
    • where in the project the API should live
    • how it should interface with existing code
      - currently /apps/modeling houses all the the code we need to run the analyze and rwd tasks
      - Determine if it should remain there and have the new api depend on it, or if the relevent operations should be extracted into their own module for both apps to use
  • Based on decisions above, add basic views for rwd and analyze tasks in the new geoprocessing-api app
@arottersman
Copy link
Author

@mmcfarland and I met and discussed a plan of action:

Where should the API live?

  • in its own geoprocessing-api django project

How should we reuse code?

A lot of ways to cut things, we talked about a few options:

  • (a) We could rewrite views in geoprocessing-api, import from modeling and leave it mostly untouched
  • (b) Matt pointed out there should only be one way to call up an analyze or RWD task, so we should move the relevant views into the geoprocessing-api.

We're going with (b). We'll save ourselves work if we ever have to change up the endpoints, and it's easier to keep a mental model of.

What about the calculations we do for analyze, constructing sql etc? Should modeling become a house for all modeling related code, or just a place for "stuff not in the api"?

  • no clear better choice. We'll have to look at specifics for what should stay/go
  • want to avoid circular dependencies
  • don't want to duplicate task utils (these for the most part seem to already be in core)

Also

  • We're going to build this work off of the collections API feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants