"Rename scenario" modal does not show on IE11 #2315
Assignees
Milestone
Comments
ajrobbins
changed the title
caseycesari
added a commit
that referenced
this issue
Oct 3, 2017
The validateNewScenarioName function is used in a _.bind call in the renameScenario function, which is called before the modal is opened. IE throws an error because the newName variable in undefined, and trim is called on that variable. It's not clear why this doesn't happen in other browsers. Refs #2315
caseycesari
added a commit
that referenced
this issue
Oct 3, 2017
Using _.curry appeared to call the validate function before it needed to be called, which resulted in a JS error and prevented the modal from being displayed. Keeping the correct scope for the validate function is slightly reworked here so that _.curry does not need to be used, which lets things work as expected in IE. Refs #2315
caseycesari
added a commit
that referenced
this issue
Oct 3, 2017
Using _.curry appeared to call the validate function before it needed to be called, which resulted in a JS error and prevented the modal from being displayed. Keeping the correct scope for the validate function is slightly reworked here so that _.curry does not need to be used, which lets things work as expected in IE. Also, update tests for new function signature. Refs #2315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observed in IE 11 on browserstack:
Created project with scenarios, selected menu option to "rename scenarios". No modal appeared, and there was no apparent way to rename a scenario.
Expected: Scenario renaming modal to appear, like so:
The text was updated successfully, but these errors were encountered: