Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GWLFE modification tooltip text wraps #2057

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Ensure GWLFE modification tooltip text wraps #2057

merged 1 commit into from
Jul 19, 2017

Conversation

caseycesari
Copy link
Member

@caseycesari caseycesari commented Jul 19, 2017 •
edited
Loading

Overview

Setting this property to normal ensures that the text in the
modification tooltip is wrapped in every browser so that it does not
extend outside of the tooltip boundary.

Connects to #2039

Demo

image
Screenshot from IE

Testing Instructions

  • In every major browser (especially IE), open a MapShed project.
  • Go to a scenario and add a modification.
  • Once the modification has been added, hover over the thumbnail in the modification sidebar, and ensure the text is always wrapped and does not extend outside of the tooltip border.

@caseycesari
Ensure GWLFE modification tooltip text wraps
c461e87 
Setting this property to normal ensures that the text in the
modification tooltip is wrapped in every browser so that it does not
extend outside of the tooltip boundary.

Refs #2039
mmcfarland
mmcfarland approved these changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved by mgt, man.

Tested in FF/Ch/IE/Edge browsers.

@caseycesari
Copy link
Member Author

Thanks!

@caseycesari caseycesari merged commit 9e504a1 into develop Jul 19, 2017
@caseycesari caseycesari deleted the cpc/fix-modification-text-wrap branch July 19, 2017 21:13
@rajadain rajadain mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcfarland mmcfarland mmcfarland approved these changes

Assignees

@caseycesari caseycesari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caseycesari @mmcfarland