Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BiGCZ: Clear results from map after leaving search page #2113

Merged
merged 2 commits into from
Aug 3, 2017

Conversation

arottersman
Copy link

Overview

The BiG-CZ data catalog results would remain on the map even after you'd navigated back to the splash page/analyze.

Connects #2054

Demo

ajsopqfv4j

Testing Instructions

  • Pull and bundle
  • Search for something that yields shapes in WDC and cinergi
  • Confirm they clear if you use the browser back navigation or click the header to go to the splash
  • Confirm you can still search another shape

@rajadain
Copy link
Member

rajadain commented Aug 2, 2017

Taking a look now.

@rajadain
Copy link
Member

rajadain commented Aug 2, 2017

If I click the home button and leave before results have finished fetching, when they do finally finish I see this error in the console:

image

Copy link
Member

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, except for that error mentioned above. I think there's enough bandwidth to handle that in this card, but if it feels too onerous feel free to offload to a future issue.

},

dataCatalogCleanUp: function() {
App.map.set('dataCatalogResults', null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also settings dataCatalogActiveResult to null for completeness:

App.map.set({
  dataCatalogResults: null,
  dataCatalogActiveResult: null,
});

@arottersman arottersman force-pushed the arr/bcz-clear-shapes-on-leave branch from 537c9ba to 87ccb91 Compare August 2, 2017 22:37
@arottersman
Copy link
Author

arottersman commented Aug 2, 2017

I rebased on #2110 to cancel searches on clean up (87ccb91). Now only the last three commits pertain to this PR.

Copy link
Member

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested, works splendidly.

@rajadain rajadain assigned arottersman and unassigned rajadain Aug 3, 2017
@arottersman arottersman force-pushed the arr/bcz-clear-shapes-on-leave branch from 87ccb91 to 81685e3 Compare August 3, 2017 13:24
@arottersman
Copy link
Author

Rebased on develop. Going to merge!

@arottersman arottersman merged commit 17bd64f into develop Aug 3, 2017
@arottersman arottersman deleted the arr/bcz-clear-shapes-on-leave branch August 3, 2017 13:38
@rajadain rajadain mentioned this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants