-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BiGCZ: Clear results from map after leaving search page #2113
Conversation
Taking a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great, except for that error mentioned above. I think there's enough bandwidth to handle that in this card, but if it feels too onerous feel free to offload to a future issue.
}, | ||
|
||
dataCatalogCleanUp: function() { | ||
App.map.set('dataCatalogResults', null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider also settings dataCatalogActiveResult
to null
for completeness:
App.map.set({
dataCatalogResults: null,
dataCatalogActiveResult: null,
});
537c9ba
to
87ccb91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested, works splendidly.
87ccb91
to
81685e3
Compare
Rebased on develop. Going to merge! |
Overview
The BiG-CZ data catalog results would remain on the map even after you'd navigated back to the splash page/analyze.
Connects #2054
Demo
Testing Instructions
bundle