Enable toggling between analyze and BigCZ results #2119
Conversation
|
Taking a look now. |
|
Cannot scroll all the way to the bottom of the Analyze tabs:
EDIT: Ah I see this has already been pointed out in the Notes section. Consider using the above gif for the separate card for this issue. |
|
This branch has a dark grey buffer at the bottom of the Search page:
which does not exist on
|
|
And opening the filters makes it worse:
|
|
This may be more of a design task (/cc @jfrankl), but really long area of interest names don't fit in the header:
In the very least, hovering on it should reveal the full name in a tooltip. We should also remove the clickability, since they don't have a dropdown menu as MMW does. Also, we have now lost the area of interest size. But that problem exists in MMW too. |
src/mmw/sass/components/_tabs.scss
Outdated
| .data-catalog-stage-results-tab-pane { | ||
| .tab-content { | ||
| // Set a specific height to allow y-scroll: | ||
| height: calc(100% - 53px) !important; |
There was a problem hiding this comment.
This is likely causing the grey box issues, since it may double the work here:
|
Also going to wait for grey box issue resolution to test. Looked over the code — LGTM. |
|
Added 72cded2 to fix the gray box issue. |
|
I am going to spend some time on the design aspects of this later today. The removal of the project saving functionality will require some adjustments. |
|
Taking another look. |
There was a problem hiding this comment.
+1 tested. Can switch back and forth, and the search page works as fully as it did before. I like the approach used, and the code looks pretty good. Nice work!
The cutoff Area of Interest and Analyze tab scrolling issues can be counted as "known issues" for now. We should make cards for them.
Allow the user to switch between the AoI analyze results, and the BigCZ search page. This implementation is based on the analyze and modeling tabs of MMW. Some views, templates, and CSS rules from that implementation were duplicated and adjusted rather than abstracting the MMW implementation and making it reusable. Refs #2095
caseycesari
force-pushed
the
cpc/search-analyze-navigation
branch
from
72cded2
to
df4e326
Compare
Overview
Allow the user to switch between the AoI analyze results, and the BigCZ search page. This implementation is based on the analyze and modeling tabs of MMW. Some views, templates, and CSS rules from that implementation were duplicated and adjusted rather than abstracting the MMW
implementation and making it reusable.
Connects #2095
Demo
Notes
As noted in the PR description and commit message, it proved to be more difficult to directly reuse the MMW components to implement this. Instead, I copied and pared down what I needed. In the short term, I think this was a easier, and less complicated approached. However, it may have drawbacks if we need to make similar changes to both apps.
Also, there were a number of CSS quirks that came up when I implemented this. I was able to fix all of them except for the height of the tab content. Currently, it is set optimally for the search results and not the analyze tab. The download button on the analyze tab is currently not completely viewable. I'll create a follow-up issue for this.
Testing Instructions