Implement details view for BiG CZ

[caseycesari]

Overview

Clicking on a search result in the BiG CZ results pane will open a pane with the details for that result. Only the fields that were common between all three APIs were added.

Connects to #1934

Demo

Notes

I tried various approaches to wiring up the events, and unfortunately, the only one I could get working was propagating the event manually. Triggering a collection event didn't work nor did using childViewEvents.

Testing Instructions

• Visit the BiGCZ site.
• Draw an AoI and make a search.
• For each API, click a few results, and verify the details view is displayed.

[arottersman]

Tested on Chrome, FF, Safari and IE11. Working well! I think this is good to merge, just a few comments:

• I think the triggerMethods are fine, and even fairly easy to follow in this case. If we do want to stay clear of events though, I was thinking we could add a method onto the ResultsCollection like setActiveResult that sets a given result to have an attribute isActive=true (and all other results to isActive=false). Then the DataCatalogWindow could listen for change:isActive on the active catalog's ResultCollection. Not sure that this is any simpler — just a thought.

• We could potentially add date to the view, as that seems to be a common feature

• Should this at some point make the corresponding result's shape active on the map?

• When the title wraps, the "x" renders below it. Not sure if now is a good time to address
  

[arottersman]

Should we also include the date as part of this card?

[caseycesari]

I didn't implement this originally because the APIs handle dates in different ways. But after rereading the card, I'm going to take a shot at it.

[arottersman]

This was a little unexpected; I didn't know you could query ui elements in child views. Consider putting this on the view that renders the template this button is in, and hooking it back up to DataCatalogWindow via childEvents (like you did for the show action).

While the childEvents aren't ideal, I think not having this ui tag on the view rendering it could trip us up down the line.

[caseycesari]

Good call. Will do.

[caseycesari]

Thanks for the thorough review.

Should this at some point make the corresponding result's shape active on the map?

Yeah, though that will be handled in a follow up card. The original description of this issue says not to do it as part of this issue. I'll make a follow up card.

When the title wraps, the "x" renders below it. Not sure if now is a good time to address

I'll see if I can fix this.

[caseycesari]

@arottersman I made the requested changes. Ready for another look!

[arottersman]

I left a review but then deleted its only comment to move it somewhere else. Now the whole review is gone....

[arottersman]

+1, looks good. Can approve this is as soon as the build passes:

The linter is failing because options is defined but never used in data_catalog/views.js

[arottersman]

We could also check if there's begin_date instead of checking on the active catalog.

[caseycesari]

I tried something similar, but there is a bit of an overlap in fields between the two catalogs, so I wanted to be more explicit. We may end up having to change this in the future too depending on how much the detail panes diverge between the catalogs.

[arottersman]

Nice! "Friendly reminder" to squash fixups

[caseycesari]

Thanks for the thorough review!