Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link CINERGI Results to Original Repository #2169

Merged
merged 4 commits into from
Aug 22, 2017
Merged

Link CINERGI Results to Original Repository #2169

merged 4 commits into from
Aug 22, 2017

Conversation

rajadain
Copy link
Member

Overview

Add a "repository" link to the CINERGI details view linking each result to the main website.

Tagging @jfrankl for visual review.

Connects #2140

Demo

2017-08-21 13 06 22

image

Testing Instructions

  • Check out this branch, bundle, and go to :8000/?bigcz
  • Search for something. Get CINERGI results back.
  • Click an any CINERGI result. Ensure that it has a Repository button.
  • Click the repository button. Ensure the same record is opened in the main CINERGI site, in a new tab.
  • Ensure HydroShare and CUAHSI tabs do not have the repository link

@rajadain
Add custom CINERGI model and serializer
25e13d9 
We are adding a CINERGI-specific `cinergi_url` field to the API
results, thus we make a custom model and serializer extending from
the base ones for CINERGI.
@rajadain
Parse CINERGI url from fileid
b3c0a3a 
Construct CINERGI repository URL from the fileid of the result
@rajadain
Use new CINERGI model to return cinergi_url
f70dfba
@rajadain
Show CINERGI repository URL in details view
7d40dd7
@rajadain rajadain requested a review from jfrankl August 21, 2017 17:19
caseycesari
caseycesari approved these changes Aug 22, 2017
View reviewed changes
Copy link
Member

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@caseycesari caseycesari assigned rajadain and unassigned caseycesari Aug 22, 2017
@rajadain rajadain merged commit bc80ace into develop Aug 22, 2017
@rajadain rajadain deleted the tt/bigcz-cinergi-link branch August 22, 2017 20:38
@rajadain
Copy link
Member Author

Thanks for taking a look!

@rajadain rajadain added the BigCZ label Sep 7, 2017
@rajadain rajadain mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseycesari caseycesari caseycesari approved these changes

@jfrankl jfrankl Awaiting requested review from jfrankl

Assignees

@rajadain rajadain

Labels
BigCZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajadain @caseycesari @hectcastro