Add NLCD code to analyze land results csv #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add hidden yet exportable column to TableView and TableRowView added only when the table displays NLCD results
caseycesari
approved these changes
Aug 23, 2017
| @@ -2,6 +2,9 @@ | |||
| <thead> | |||
| <tr> | |||
| <th data-sortable="true">Type</th> | |||
| {% if isLandTable %} | |||
| <th class="hidden-analyze-table-column" data-tableexport-display="always">NLCD Code</th> | |||
There was a problem hiding this comment.
Consider dropping this class and using the HTML hidden attribute.
There was a problem hiding this comment.
Tried this out & it seemed like there's some quirk getting the hidden attribute to take hold via the Nunjucks template.
Going to leave this as is for now, but we should try it again if we end up adjusting these to include more hidden columns.
|
Thanks for taking a look at this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an "NLCD Code" column to the exported CSV, but not to the visible analyze results table. We accomplish this by adding a hidden column to the table which is registered to be exported along with the CSV.
Since both the land and soils tab use the TableView component, the changes here also include some checks for whether or not to add the hidden column. If we decide we want to show a soil code for that table, we can drop the checks in the template and instead pick the value and header text conditionally.
Connects #2127
Demo
->
Testing Instructions
vagrant upandbundle