Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare View Revamp: TR-55 Water Quality Charts and Table #2177

Merged
merged 6 commits into from
Aug 24, 2017
Merged

Compare View Revamp: TR-55 Water Quality Charts and Table #2177

merged 6 commits into from
Aug 24, 2017

Commits on Aug 24, 2017

  1. Add TR-55 Water Quality Table

    @rajadain
    rajadain committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    1c9e2be View commit details
    Browse the repository at this point in the history

  2. Add TR-55 Water Quality Charts

    @rajadain
    rajadain committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    a1e9cbe View commit details
    Browse the repository at this point in the history

  3. Add configurable unit label to charts

    @rajadain
    rajadain committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    392aa6f View commit details
    Browse the repository at this point in the history

  4. Enable tab switching 

    When a tab is clicked, it's model is set to have {active: true}.
We use Marionette events that bubble up the chain, triggering
re-renders of all relevant features.
    @rajadain
    rajadain committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    2614c98 View commit details
    Browse the repository at this point in the history

  5. Improve chart / table switching 

    Previously the switching would work, but the icons would not
update. Now we add or remove the `active` class as necessary.

I tried doing this via `modelEvents: { 'change:mode': 'render' }`,
but that would get rid of the precipitation control added in
`onShow`. This seemed like the best second option.
    @rajadain
    rajadain committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    e250c1d View commit details
    Browse the repository at this point in the history

  6. Make y-axis tick precision dynamic 

    In case of a stacked chart, or when the minimum y-value is
more than 1, we use the 0.1f format which is 1 decimal place.
For when the value is less than 1, we calculate how deep is
the most significant digit of the smallest non-zero y-value,
and set that as the tick precision.

See https://github.com/d3/d3-format for details.
    @rajadain
    rajadain committed Aug 24, 2017
    Configuration menu
    Copy the full SHA
    85a3820 View commit details
    Browse the repository at this point in the history